Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Simon had requested some docs on what all our test options do, so lets clean it up and doc it.

      i propose:

      1. change all vars to be tests.xxx (e.g. tests.threadspercpu, tests.multiplier, ...)
      2. ensure all 6 build systems (lucene, solr, each solr contrib) respect these.
      3. add a simple wiki page listing what these do.
      1. LUCENE-2619.patch
        12 kB
        Robert Muir
      2. LUCENE-2619.patch
        11 kB
        Robert Muir

        Activity

        Grant Ingersoll made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12564307 ] jira [ 12584841 ]
        Mark Thomas made changes -
        Workflow jira [ 12518769 ] Default workflow, editable Closed status [ 12564307 ]
        Hide
        Simon Willnauer added a comment -

        Thank you for adding the doc page! Very much appreciated!

        Simon

        Show
        Simon Willnauer added a comment - Thank you for adding the doc page! Very much appreciated! Simon
        Robert Muir made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Hide
        Robert Muir added a comment -

        OK, initial wiki page is here: http://wiki.apache.org/lucene-java/RunningTests

        Show
        Robert Muir added a comment - OK, initial wiki page is here: http://wiki.apache.org/lucene-java/RunningTests
        Hide
        Robert Muir added a comment -

        OK I committed these changes to trunk (988527) and 3x (988536).

        I'll mark this resolved when the wiki page is done.

        Show
        Robert Muir added a comment - OK I committed these changes to trunk (988527) and 3x (988536). I'll mark this resolved when the wiki page is done.
        rmuir committed 988536 (59 files)
        Reviews: none

        LUCENE-2619: improve test system (consistency of var names, args, sysprops passed to solr contribs, etc)

        Lucene branch_3x
        rmuir committed 988529 (4 files)
        Robert Muir made changes -
        Attachment LUCENE-2619.patch [ 12452926 ]
        Hide
        Robert Muir added a comment -

        attach is an updated patch:

        I completely disabled this solr "dir.prop" for tests, as it doesn't work at all.
        In the first patch i tried to pass this (like all other props/args) to all the tests for the contribs too.

        But this was being unconditionally set to "" in the core test macro itself, so its completely useless.

        Show
        Robert Muir added a comment - attach is an updated patch: I completely disabled this solr "dir.prop" for tests, as it doesn't work at all. In the first patch i tried to pass this (like all other props/args) to all the tests for the contribs too. But this was being unconditionally set to "" in the core test macro itself, so its completely useless.
        Robert Muir made changes -
        Field Original Value New Value
        Attachment LUCENE-2619.patch [ 12452923 ]
        Robert Muir created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development