Lucene - Core
  1. Lucene - Core
  2. LUCENE-2596

Impl toString() in MergePolicy and its extensions

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1, 4.0-ALPHA
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      These can be important to see for debugging.

      We lost them in the cutover to IWC.

      Just opening this issue to remind us to get them back, before releasing...

        Activity

        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1
        Hide
        Shai Erera added a comment -

        Committed revision 988512 (3x).
        Committed revision 988517 (trunk).

        Show
        Shai Erera added a comment - Committed revision 988512 (3x). Committed revision 988517 (trunk).
        Hide
        Shai Erera added a comment -

        Adds the toString() impls

        Show
        Shai Erera added a comment - Adds the toString() impls
        Hide
        Shai Erera added a comment -

        Renaming subject to a more accurate one. Will post a patch soon.

        Show
        Shai Erera added a comment - Renaming subject to a more accurate one. Will post a patch soon.
        Hide
        Michael McCandless added a comment -

        Hmm it looks like IW has never included useCFS/mergeFactor in its infoStream output... (weird! I thought they did).

        So this is not in fact a regression!

        But still let's fix the MPs to have an "interesting" toString that includes their settings (not just useCFS/mergeFactor but other interesting ones like maxMergeDocs/MB, minMergeDocs/MB too).

        Show
        Michael McCandless added a comment - Hmm it looks like IW has never included useCFS/mergeFactor in its infoStream output... (weird! I thought they did). So this is not in fact a regression! But still let's fix the MPs to have an "interesting" toString that includes their settings (not just useCFS/mergeFactor but other interesting ones like maxMergeDocs/MB, minMergeDocs/MB too).
        Hide
        Shai Erera added a comment -

        This line

                    "mergePolicy=" + mergePolicy + "\n" + 
        

        is redundant as it's printed from config.toString(). So if you intend to fix anything here, this line should be removed.

        Show
        Shai Erera added a comment - This line "mergePolicy=" + mergePolicy + "\n" + is redundant as it's printed from config.toString(). So if you intend to fix anything here, this line should be removed.
        Hide
        Shai Erera added a comment -

        Mike, messageState() looks like this:

          private void messageState() {
            message("\ndir=" + directory + "\n" +
                    "mergePolicy=" + mergePolicy + "\n" + 
                    "index=" + segString() + "\n" +
                    "version=" + Constants.LUCENE_VERSION + "\n" +
                    config.toString());
          }
        

        There is a config.toString() printout which includes all of IWC info. Is something else missing?

        Show
        Shai Erera added a comment - Mike, messageState() looks like this: private void messageState() { message( "\ndir=" + directory + "\n" + "mergePolicy=" + mergePolicy + "\n" + "index=" + segString() + "\n" + "version=" + Constants.LUCENE_VERSION + "\n" + config.toString()); } There is a config.toString() printout which includes all of IWC info. Is something else missing?

          People

          • Assignee:
            Shai Erera
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development