Lucene - Core
  1. Lucene - Core
  2. LUCENE-2595

most tests should use MockRAMDirectory not RAMDirectory

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New
    1. LUCENE-2595.patch
      199 kB
      Robert Muir
    2. LUCENE-2595.patch
      196 kB
      Robert Muir

      Activity

      Hide
      Robert Muir added a comment -

      heres a patch switching tests over (some fail, i didnt even look at resolving these yet).

      I think once we fix this, we can look at moving the test system where it tests a variety of directory impls and supports something like -Dtests.directoryImpl= or something like that to run all the tests against a specific impl.

      Show
      Robert Muir added a comment - heres a patch switching tests over (some fail, i didnt even look at resolving these yet). I think once we fix this, we can look at moving the test system where it tests a variety of directory impls and supports something like -Dtests.directoryImpl= or something like that to run all the tests against a specific impl.
      Hide
      Robert Muir added a comment -

      updated patch: all tests pass.

      I did add one TODO to investigate in TestIW:

          public void testCommitOnCloseOptimize() throws IOException {
            MockRAMDirectory dir = new MockRAMDirectory();  
            dir.setPreventDoubleWrite(false); // TODO: should this be disabled here?
      
      Show
      Robert Muir added a comment - updated patch: all tests pass. I did add one TODO to investigate in TestIW: public void testCommitOnCloseOptimize() throws IOException { MockRAMDirectory dir = new MockRAMDirectory(); dir.setPreventDoubleWrite( false ); // TODO: should this be disabled here?
      Hide
      Robert Muir added a comment -

      Committed revision 984232. I'll backport LUCENE-2594 to 3x first.

      Show
      Robert Muir added a comment - Committed revision 984232. I'll backport LUCENE-2594 to 3x first.
      Hide
      Robert Muir added a comment -

      Committed revision 984299 to 3x

      Show
      Robert Muir added a comment - Committed revision 984299 to 3x
      Hide
      Grant Ingersoll added a comment -

      Bulk close for 3.1

      Show
      Grant Ingersoll added a comment - Bulk close for 3.1

        People

        • Assignee:
          Unassigned
          Reporter:
          Robert Muir
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development