Lucene - Core
  1. Lucene - Core
  2. LUCENE-2581

FastVectorHighlighter: Make FragmentsBuilder use Encoder

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.2
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: modules/highlighter
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Make FragmentsBuilder use Encoder, as Highlighter does.

      1. LUCENE-2581.patch
        16 kB
        Koji Sekiguchi
      2. LUCENE-2581.patch
        14 kB
        Koji Sekiguchi
      3. LUCENE-2581.patch
        10 kB
        Koji Sekiguchi

        Issue Links

          Activity

          Hide
          Grant Ingersoll added a comment -

          Bulk close for 3.1

          Show
          Grant Ingersoll added a comment - Bulk close for 3.1
          Hide
          Koji Sekiguchi added a comment -

          trunk: Committed revision 982824.
          branch_3x: Committed revision 982828.

          Show
          Koji Sekiguchi added a comment - trunk: Committed revision 982824. branch_3x: Committed revision 982828.
          Hide
          Koji Sekiguchi added a comment -

          I'll commit tomorrow.

          Show
          Koji Sekiguchi added a comment - I'll commit tomorrow.
          Hide
          Koji Sekiguchi added a comment -

          As I change the FragmentsBuilder interface in this ticket, I want to use this opportunity to take tag arrays in the added methods. This change enables tags to be set per-field override in Solr.

          Show
          Koji Sekiguchi added a comment - As I change the FragmentsBuilder interface in this ticket, I want to use this opportunity to take tag arrays in the added methods. This change enables tags to be set per-field override in Solr.
          Hide
          Koji Sekiguchi added a comment -

          JUnit test added.

          Show
          Koji Sekiguchi added a comment - JUnit test added.
          Hide
          Koji Sekiguchi added a comment -

          This patch breaks back-compat because I added two methods that take Encoder to FragmentsBuilder interface. But using the methods bring in "per-field override" feature in Solr.

          Show
          Koji Sekiguchi added a comment - This patch breaks back-compat because I added two methods that take Encoder to FragmentsBuilder interface. But using the methods bring in "per-field override" feature in Solr.

            People

            • Assignee:
              Koji Sekiguchi
              Reporter:
              Koji Sekiguchi
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development