Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Now that term is byte[], we should switch collation to use byte[] instead of 'indexablebinarystring'.

      This is faster and results in much smaller sort keys.

      I figure we can work it out here, and fix termrangequery to use byte in parallel, but we can already test sorting etc now.

      1. LUCENE-2551.patch
        23 kB
        Robert Muir
      2. LUCENE-2551.patch
        32 kB
        Robert Muir

        Issue Links

          Activity

          Robert Muir created issue -
          Hide
          Robert Muir added a comment -

          attached is a quick prototype.

          I kept the old representation working via Version. if you use >= 4.0, it just encodes to byte.

          I figure this has enough violations that Uwe will jump in and help

          Show
          Robert Muir added a comment - attached is a quick prototype. I kept the old representation working via Version. if you use >= 4.0, it just encodes to byte. I figure this has enough violations that Uwe will jump in and help
          Robert Muir made changes -
          Field Original Value New Value
          Attachment LUCENE-2551.patch [ 12449894 ]
          Hide
          Robert Muir added a comment -

          Updated patch, with javadocs, and attributefactory violations corrected.

          I think this patch is ready, but we should probably fix a few things (TermRangeQuery, QueryParser should consume with BytesRef not string) first.

          Show
          Robert Muir added a comment - Updated patch, with javadocs, and attributefactory violations corrected. I think this patch is ready, but we should probably fix a few things (TermRangeQuery, QueryParser should consume with BytesRef not string) first.
          Robert Muir made changes -
          Attachment LUCENE-2551.patch [ 12449924 ]
          Hide
          Robert Muir added a comment -

          I looked at some of the keys in the test code, and encoding directly as byte results in keys nearly 1/2 the size (in bytes) of the previous encoding.

          Show
          Robert Muir added a comment - I looked at some of the keys in the test code, and encoding directly as byte results in keys nearly 1/2 the size (in bytes) of the previous encoding.
          Robert Muir made changes -
          Link This issue depends on LUCENE-2514 [ LUCENE-2514 ]
          Mark Thomas made changes -
          Workflow jira [ 12516069 ] Default workflow, editable Closed status [ 12563717 ]
          Mark Thomas made changes -
          Workflow Default workflow, editable Closed status [ 12563717 ] jira [ 12585272 ]
          Hide
          Robert Muir added a comment -

          Committed revision 1075210.

          Show
          Robert Muir added a comment - Committed revision 1075210.
          Robert Muir made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Shai Erera made changes -
          Component/s modules/analysis [ 12310230 ]
          Component/s contrib/analyzers [ 12312333 ]
          Gavin made changes -
          Link This issue depends on LUCENE-2514 [ LUCENE-2514 ]
          Gavin made changes -
          Link This issue depends upon LUCENE-2514 [ LUCENE-2514 ]
          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          223d 6h 55m 1 Robert Muir 28/Feb/11 05:17
          Resolved Resolved Closed Closed
          802d 5h 26m 1 Uwe Schindler 10/May/13 10:44

            People

            • Assignee:
              Unassigned
              Reporter:
              Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development