Lucene - Core
  1. Lucene - Core
  2. LUCENE-2542

TopDocsCollector should be abstract super class that is the real "TopDocsCollector" contract, a subclass should implement the priority-queue logic. e.g. PQTopDocsCollector

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      TopDocsCollector is both an abstract interface for producing TopDocs as well as a PriorityQueue based implementation.
      Not all Collectors that could produce TopDocs must use a PriorityQueue, and it would be advantageous to allow the TopDocsCollector to be an "interface" type abstract class, with a PQTopDocsCollector sub-class.
      While doing this, it'd be good to clean up the generics uses in these classes. As it's odd to create a TopFieldCollector and have to case the TopDocs object, when this can be fixed with generics.

      1. LUCENE-2542.patch
        38 kB
        Woody Anderson
      2. LUCENE-2542.patch
        5 kB
        Woody Anderson
      3. LUCENE-2542.patch
        3 kB
        Woody Anderson
      4. LUCENE_3.0.2-2542.patch
        35 kB
        Woody Anderson

        Activity

        Grant Ingersoll made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12564337 ] jira [ 12584867 ]
        Mark Thomas made changes -
        Workflow jira [ 12515945 ] Default workflow, editable Closed status [ 12564337 ]
        Yonik Seeley made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Shai Erera made changes -
        Fix Version/s 3.1 [ 12314822 ]
        Affects Version/s 3.0.2 [ 12314798 ]
        Lucene Fields [New] [New, Patch Available]
        Woody Anderson made changes -
        Attachment LUCENE-2542.patch [ 12450012 ]
        Woody Anderson made changes -
        Attachment LUCENE-2542.patch [ 12449905 ]
        Woody Anderson made changes -
        Attachment LUCENE-2542.patch [ 12449774 ]
        Woody Anderson made changes -
        Attachment LUCENE_3.0.2-2542.patch [ 12449773 ]
        Uwe Schindler made changes -
        Field Original Value New Value
        Fix Version/s 3.0.2 [ 12314798 ]
        Lucene Fields [New, Patch Available] [New]
        Woody Anderson created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Woody Anderson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development