Lucene - Core
  1. Lucene - Core
  2. LUCENE-2517

changes-to-html: fixes and improvements

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      The Lucene Hudson Changes.html looks bad because changes2html.pl doesn't properly handle some new usages in CHANGES.txt.

      1. LUCENE-2517.patch
        4 kB
        Steve Rowe
      2. LUCENE-2517-CHANGES.patch
        4 kB
        Steve Rowe
      3. LUCENE-2517-branch3x-CHANGES.patch
        1 kB
        Steve Rowe

        Activity

        Hide
        Steve Rowe added a comment -

        This patch addresses the following issues:

        1. Release headers (==== Release X.X.X .... ====) can be spelled with "Lucene" instead of "Release": ==== Lucene X.X.X ... ====
        2. Release versions can have .X, .Y or .Z components (e.g. 3.x)
        3. JavaScript isOlder() method had a (no longer correct) hard-coded regex to recognize the two latest releases. This regex is now generated from the two latest releases.
        4. <code> -> <code><pre> (to make them look better in HTML) is now blocked for inline usages, so that newlines are not added to the HTML version when they are not present in CHANGES.txt.
        5. Imbalanced parentheses were incorrectly recognized as attribution onset.
        Show
        Steve Rowe added a comment - This patch addresses the following issues: Release headers (==== Release X.X.X .... ====) can be spelled with "Lucene" instead of "Release": ==== Lucene X.X.X ... ==== Release versions can have .X, .Y or .Z components (e.g. 3.x) JavaScript isOlder() method had a (no longer correct) hard-coded regex to recognize the two latest releases. This regex is now generated from the two latest releases. <code> -> <code><pre> (to make them look better in HTML) is now blocked for inline usages, so that newlines are not added to the HTML version when they are not present in CHANGES.txt. Imbalanced parentheses were incorrectly recognized as attribution onset.
        Hide
        Steve Rowe added a comment -

        This patch contains several typo fixes for CHANGES.txt, and one change: the first item under Changes in backwards compatibility policy (LUCENE-1458, LUCENE-2111, LUCENE-2354: Changes from flexible indexing) includes attribution for individual bulleted items, which is a new usage that I think is not intended (copy-paste-o, likely), and several of the people that worked on those three issues are not given credit anywhere AFAICT, so I've moved the attributions attached to bulleted items to below the entire bulleted list, and added everyone who posted a patch to any of the three issues.

        Show
        Steve Rowe added a comment - This patch contains several typo fixes for CHANGES.txt, and one change: the first item under Changes in backwards compatibility policy ( LUCENE-1458 , LUCENE-2111 , LUCENE-2354 : Changes from flexible indexing) includes attribution for individual bulleted items, which is a new usage that I think is not intended (copy-paste-o, likely), and several of the people that worked on those three issues are not given credit anywhere AFAICT, so I've moved the attributions attached to bulleted items to below the entire bulleted list, and added everyone who posted a patch to any of the three issues.
        Hide
        Michael McCandless added a comment -

        Looks good! I'll commit shortly. I don't understand the Perl But I ran "ant changes-to-html" and the output looks good

        Show
        Michael McCandless added a comment - Looks good! I'll commit shortly. I don't understand the Perl But I ran "ant changes-to-html" and the output looks good
        Hide
        Michael McCandless added a comment -

        Steven can you post a 3x only patch for your fixes to lucene/CHANGES.txt? Looks like most of your fixes were on trunk-only entries? Thanks.

        Show
        Michael McCandless added a comment - Steven can you post a 3x only patch for your fixes to lucene/CHANGES.txt? Looks like most of your fixes were on trunk-only entries? Thanks.
        Hide
        Steve Rowe added a comment -

        Steven can you post a 3x only patch for your fixes to lucene/CHANGES.txt? Looks like most of your fixes were on trunk-only entries?

        This patch addresses the only two (very minor) differences that were in both trunk and the 3.x branch.

        Show
        Steve Rowe added a comment - Steven can you post a 3x only patch for your fixes to lucene/CHANGES.txt? Looks like most of your fixes were on trunk-only entries? This patch addresses the only two (very minor) differences that were in both trunk and the 3.x branch.
        Hide
        Michael McCandless added a comment -

        Thanks Steven!

        Show
        Michael McCandless added a comment - Thanks Steven!
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Steve Rowe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development