Lucene - Core
  1. Lucene - Core
  2. LUCENE-2486

when opening the merged SegmentReader, IW attempts to open store files that were deleted

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.3, 3.0.2, 3.1, 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      The issue happens when a merge runs that does not merge the doc stores, those doc stores are still being written to, IW is using CFS, and while the merge is running the doc stores get closed and turned into a cfx file.

      When we then try to open the reader (for warming), which as of LUCENE-2311 will now [correctly] open the doc stores, we hit FNFE because the SegmentInfo for the merge does not realize that the doc stores were turned into a cfx.

      This issue does affect trunk; if you crank up the #docs in the test, it happens consistently (I will tie this to _TestUtil.getRandomMultiplier!).

      1. LUCENE-2486.patch
        6 kB
        Michael McCandless

        Activity

        Michael McCandless created issue -
        Hide
        Michael McCandless added a comment -

        The fix was simple: move the logic for setting the docStoreIsCompoundFile on the merge's SegmentInfo up higher, to before we open the reader for warming, as well as incRef'ing the files for the merged segment.

        Show
        Michael McCandless added a comment - The fix was simple: move the logic for setting the docStoreIsCompoundFile on the merge's SegmentInfo up higher, to before we open the reader for warming, as well as incRef'ing the files for the merged segment.
        Michael McCandless made changes -
        Field Original Value New Value
        Attachment LUCENE-2486.patch [ 12446359 ]
        Michael McCandless made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Mark Thomas made changes -
        Workflow jira [ 12512570 ] Default workflow, editable Closed status [ 12564278 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12564278 ] jira [ 12584093 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        1h 31m 1 Michael McCandless 04/Jun/10 20:38
        Resolved Resolved Closed Closed
        13d 12h 25m 1 Uwe Schindler 18/Jun/10 09:04

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development