Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.9
    • Component/s: modules/analysis
    • Labels:
      None
    • Environment:

      Operating System: other
      Platform: Other

    • Bugzilla Id:
      30327

      Description

      Wanted to have the ability to ignore case in the stop filter. In some cases, I
      don't want to have to lower case before passing through the stop filter, b/c I
      may need case preserved for other analysis further down the stream, yet I don't
      need the stopwords and I don't want to have to apply stopword filters twice.

        Activity

        Hide
        grant_ingersoll@yahoo.com Grant Ingersoll added a comment -

        Created an attachment (id=12228)
        Add ignoreCase option to constructor and code

        Show
        grant_ingersoll@yahoo.com Grant Ingersoll added a comment - Created an attachment (id=12228) Add ignoreCase option to constructor and code
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        This patch is over a year old... looks like we need a refresh.

        The implementation options are this patch, or a new class (IgnoreCaseStopFilter).
        I vote for this patch (modifying the current StopFilter), as the overhead of checking a boolean variable should be negligible compared to a lookup in the stopset.

        Show
        yseeley@gmail.com Yonik Seeley added a comment - This patch is over a year old... looks like we need a refresh. The implementation options are this patch, or a new class (IgnoreCaseStopFilter). I vote for this patch (modifying the current StopFilter), as the overhead of checking a boolean variable should be negligible compared to a lookup in the stopset.
        Hide
        lucenebugs@danielnaber.de Daniel Naber added a comment -

        I think it's okay to committ this patch. Maybe just the lines with "ignoreCase == false ? ..." could be made more readable by using an if clause.

        Show
        lucenebugs@danielnaber.de Daniel Naber added a comment - I think it's okay to committ this patch. Maybe just the lines with "ignoreCase == false ? ..." could be made more readable by using an if clause.
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        fixed a constructor bug, tweaked javadoc, added a simple test case, committed, and resolving.

        Thanks for the patch Grant!

        Show
        yseeley@gmail.com Yonik Seeley added a comment - fixed a constructor bug, tweaked javadoc, added a simple test case, committed, and resolving. Thanks for the patch Grant!

          People

          • Assignee:
            yseeley@gmail.com Yonik Seeley
            Reporter:
            grant_ingersoll@yahoo.com Grant Ingersoll
          • Votes:
            2 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development