[LUCENE-2422] don't reuse byte[] in IndexInput/Output for read/writeString

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.3, 3.0.2, 3.1, 4.0-ALPHA
• Component/s: core/index
• Lucene Fields: New
• Assignee: Michael McCandless
• Reporter: Michael McCandless
• Created: 29/Apr/10 20:01
• Updated: 18/Jun/10 08:04
• Resolved: 04/May/10 18:56

Description

IndexInput now holds a private "byte[] bytes", which it re-uses for reading strings. Likewise, IndexOutput holds a UTF8Result (which holds "byte[] bytes"), re-used for writing strings.

These are both dangerous, since on reading or writing immense strings, we never free this storage.

We don't use read/writeString in very perf sensitive parts of the code, so, I think we should not reuse the byte[] at all.

I think this is likely the cause of the recent "IndexWriter and memory usage" thread, started by Ross Woolf on java-user@.