Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-2397

SnapshotDeletionPolicy.snapshot() throws NPE if no commits happened

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 2.9.3, 3.0.2, 3.1, 4.0-ALPHA
        • Component/s: core/index
        • Labels:
          None
        • Lucene Fields:
          New, Patch Available

          Description

          SDP throws NPE if no commits occurred and snapshot() was called. I will replace it w/ throwing IllegalStateException. I'll also move TestSDP from o.a.l to o.a.l,index. I'll post a patch soon

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            shaie Shai Erera added a comment -

            Patch fixes SDP, adds relevant test to TestSDP and move TestSDP to o.a.l.index. To apply the patch you first need to run:

            svn mv lucene/src/test/org/apache/lucene/TestSnapshotDeletionPolicy.java lucene/src/test/org/apache/lucene/index/TestSnapshotDeletionPolicy.java

            Show
            shaie Shai Erera added a comment - Patch fixes SDP, adds relevant test to TestSDP and move TestSDP to o.a.l.index. To apply the patch you first need to run: svn mv lucene/src/test/org/apache/lucene/TestSnapshotDeletionPolicy.java lucene/src/test/org/apache/lucene/index/TestSnapshotDeletionPolicy.java
            Hide
            Permalink
            shaie Shai Erera added a comment -

            I plan to commit this shortly.

            Show
            shaie Shai Erera added a comment - I plan to commit this shortly.
            Hide
            Permalink
            shaie Shai Erera added a comment -

            Committed revision 935522.

            Show
            shaie Shai Erera added a comment - Committed revision 935522.
            Hide
            Permalink
            shaie Shai Erera added a comment -

            Backport to 3.1

            Show
            shaie Shai Erera added a comment - Backport to 3.1
            Hide
            Permalink
            shaie Shai Erera added a comment -

            Committed revision 941427.

            Show
            shaie Shai Erera added a comment - Committed revision 941427.
            Hide
            Permalink
            mikemccand Michael McCandless added a comment -

            backport

            Show
            mikemccand Michael McCandless added a comment - backport

              People

              • Assignee:
                shaie Shai Erera
                Reporter:
                shaie Shai Erera
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development