Lucene - Core
  1. Lucene - Core
  2. LUCENE-2385

Move NoDeletionPolicy from benchmark to core

    Details

    • Lucene Fields:
      New, Patch Available

      Description

      As the subject says, but I'll also make it a singleton + add some unit tests, as well as some documentation. I'll post a patch hopefully today.

      1. LUCENE-2385.patch
        14 kB
        Shai Erera
      2. LUCENE-2385.patch
        14 kB
        Shai Erera

        Activity

        Hide
        Shai Erera added a comment -

        Move NoDeletionPolicy to core, adds javadocs + TestNoDeletionPolicy. Also includes the relevant changes to benchmark (algorithms + CreateIndexTask).
        I've fixed a typo I had in NoMergeScheduler - not related to this issue, but since it was just a typo, thought it's no harm to do it here.

        Tests pass. Planning to commit shortly.

        Show
        Shai Erera added a comment - Move NoDeletionPolicy to core, adds javadocs + TestNoDeletionPolicy. Also includes the relevant changes to benchmark (algorithms + CreateIndexTask). I've fixed a typo I had in NoMergeScheduler - not related to this issue, but since it was just a typo, thought it's no harm to do it here. Tests pass. Planning to commit shortly.
        Hide
        Uwe Schindler added a comment -

        The patch does not look like you svn moved the files. To preserve history, you should do a "svn move" of the file in your local repository and then modify it to reflect the package changes (if any).

        Did you do this?

        Show
        Uwe Schindler added a comment - The patch does not look like you svn moved the files. To preserve history, you should do a "svn move" of the file in your local repository and then modify it to reflect the package changes (if any). Did you do this?
        Hide
        Shai Erera added a comment -

        I did that first, but then remembered that when I did that in the past, people were unable to apply my patches, w/o doing the svn move themselves. Anyway, for this file it's not really important I think - a very simple and tiny file, w/ no history to preserve? Is that ok for this file (b/c I have no idea how to do the svn move now ... after I've made all the changes already)

        Show
        Shai Erera added a comment - I did that first, but then remembered that when I did that in the past, people were unable to apply my patches, w/o doing the svn move themselves. Anyway, for this file it's not really important I think - a very simple and tiny file, w/ no history to preserve? Is that ok for this file (b/c I have no idea how to do the svn move now ... after I've made all the changes already)
        Hide
        Uwe Schindler added a comment -

        In general we place a list of all svn move/copy command together with the patch, executeable from the root dir. If you paste those commands into your terminal and then apply the patch, it works. One example is the jflex issue (ok, the commands are shortened).

        Another possibility is to have a second checkout, where you arrange the files correctly (svn moved/copied) and one for creating the patches.

        Show
        Uwe Schindler added a comment - In general we place a list of all svn move/copy command together with the patch, executeable from the root dir. If you paste those commands into your terminal and then apply the patch, it works. One example is the jflex issue (ok, the commands are shortened). Another possibility is to have a second checkout, where you arrange the files correctly (svn moved/copied) and one for creating the patches.
        Hide
        Shai Erera added a comment -

        Is it better now?

        Show
        Shai Erera added a comment - Is it better now?
        Hide
        Shai Erera added a comment -

        Forgot to mention that the only move I made was of NoDeletionPolicy:

        svn move contrib/benchmark/src/java/org/apache/lucene/benchmark/utils/NoDeletionPolicy.java src/java/org/apache/lucene/index/NoDeletionPolicy.java

        I'll remember that in the future Uwe - thanks for the heads up !

        Show
        Shai Erera added a comment - Forgot to mention that the only move I made was of NoDeletionPolicy: svn move contrib/benchmark/src/java/org/apache/lucene/benchmark/utils/NoDeletionPolicy.java src/java/org/apache/lucene/index/NoDeletionPolicy.java I'll remember that in the future Uwe - thanks for the heads up !
        Hide
        Uwe Schindler added a comment -

        Yeah thats fine!

        Show
        Uwe Schindler added a comment - Yeah thats fine!
        Hide
        Shai Erera added a comment -

        Committed revision 932129.

        Show
        Shai Erera added a comment - Committed revision 932129.
        Hide
        Shai Erera added a comment -

        backport to 3.1

        Show
        Shai Erera added a comment - backport to 3.1
        Hide
        Shai Erera added a comment -

        Committed revision 941460.

        Show
        Shai Erera added a comment - Committed revision 941460.
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development