Lucene - Core
  1. Lucene - Core
  2. LUCENE-2385

Move NoDeletionPolicy from benchmark to core

    Details

    • Lucene Fields:
      New, Patch Available

      Description

      As the subject says, but I'll also make it a singleton + add some unit tests, as well as some documentation. I'll post a patch hopefully today.

      1. LUCENE-2385.patch
        14 kB
        Shai Erera
      2. LUCENE-2385.patch
        14 kB
        Shai Erera

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        3h 38m 1 Shai Erera 08/Apr/10 22:36
        Resolved Resolved Reopened Reopened
        26d 22h 30m 1 Shai Erera 05/May/10 21:06
        Reopened Reopened Resolved Resolved
        4m 12s 1 Shai Erera 05/May/10 21:11
        Resolved Resolved Closed Closed
        328d 19h 38m 1 Grant Ingersoll 30/Mar/11 16:49
        Grant Ingersoll made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Grant Ingersoll added a comment -

        Bulk close for 3.1

        Show
        Grant Ingersoll added a comment - Bulk close for 3.1
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12563485 ] jira [ 12585082 ]
        Mark Thomas made changes -
        Workflow jira [ 12507895 ] Default workflow, editable Closed status [ 12563485 ]
        Shai Erera made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Shai Erera added a comment -

        Committed revision 941460.

        Show
        Shai Erera added a comment - Committed revision 941460.
        Shai Erera made changes -
        Fix Version/s 3.1 [ 12314822 ]
        Shai Erera made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Shai Erera added a comment -

        backport to 3.1

        Show
        Shai Erera added a comment - backport to 3.1
        Shai Erera made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Shai Erera added a comment -

        Committed revision 932129.

        Show
        Shai Erera added a comment - Committed revision 932129.
        Hide
        Uwe Schindler added a comment -

        Yeah thats fine!

        Show
        Uwe Schindler added a comment - Yeah thats fine!
        Hide
        Shai Erera added a comment -

        Forgot to mention that the only move I made was of NoDeletionPolicy:

        svn move contrib/benchmark/src/java/org/apache/lucene/benchmark/utils/NoDeletionPolicy.java src/java/org/apache/lucene/index/NoDeletionPolicy.java

        I'll remember that in the future Uwe - thanks for the heads up !

        Show
        Shai Erera added a comment - Forgot to mention that the only move I made was of NoDeletionPolicy: svn move contrib/benchmark/src/java/org/apache/lucene/benchmark/utils/NoDeletionPolicy.java src/java/org/apache/lucene/index/NoDeletionPolicy.java I'll remember that in the future Uwe - thanks for the heads up !
        Shai Erera made changes -
        Attachment LUCENE-2385.patch [ 12441208 ]
        Hide
        Shai Erera added a comment -

        Is it better now?

        Show
        Shai Erera added a comment - Is it better now?
        Hide
        Uwe Schindler added a comment -

        In general we place a list of all svn move/copy command together with the patch, executeable from the root dir. If you paste those commands into your terminal and then apply the patch, it works. One example is the jflex issue (ok, the commands are shortened).

        Another possibility is to have a second checkout, where you arrange the files correctly (svn moved/copied) and one for creating the patches.

        Show
        Uwe Schindler added a comment - In general we place a list of all svn move/copy command together with the patch, executeable from the root dir. If you paste those commands into your terminal and then apply the patch, it works. One example is the jflex issue (ok, the commands are shortened). Another possibility is to have a second checkout, where you arrange the files correctly (svn moved/copied) and one for creating the patches.
        Hide
        Shai Erera added a comment -

        I did that first, but then remembered that when I did that in the past, people were unable to apply my patches, w/o doing the svn move themselves. Anyway, for this file it's not really important I think - a very simple and tiny file, w/ no history to preserve? Is that ok for this file (b/c I have no idea how to do the svn move now ... after I've made all the changes already)

        Show
        Shai Erera added a comment - I did that first, but then remembered that when I did that in the past, people were unable to apply my patches, w/o doing the svn move themselves. Anyway, for this file it's not really important I think - a very simple and tiny file, w/ no history to preserve? Is that ok for this file (b/c I have no idea how to do the svn move now ... after I've made all the changes already)
        Hide
        Uwe Schindler added a comment -

        The patch does not look like you svn moved the files. To preserve history, you should do a "svn move" of the file in your local repository and then modify it to reflect the package changes (if any).

        Did you do this?

        Show
        Uwe Schindler added a comment - The patch does not look like you svn moved the files. To preserve history, you should do a "svn move" of the file in your local repository and then modify it to reflect the package changes (if any). Did you do this?
        Shai Erera made changes -
        Field Original Value New Value
        Attachment LUCENE-2385.patch [ 12441205 ]
        Hide
        Shai Erera added a comment -

        Move NoDeletionPolicy to core, adds javadocs + TestNoDeletionPolicy. Also includes the relevant changes to benchmark (algorithms + CreateIndexTask).
        I've fixed a typo I had in NoMergeScheduler - not related to this issue, but since it was just a typo, thought it's no harm to do it here.

        Tests pass. Planning to commit shortly.

        Show
        Shai Erera added a comment - Move NoDeletionPolicy to core, adds javadocs + TestNoDeletionPolicy. Also includes the relevant changes to benchmark (algorithms + CreateIndexTask). I've fixed a typo I had in NoMergeScheduler - not related to this issue, but since it was just a typo, thought it's no harm to do it here. Tests pass. Planning to commit shortly.
        Shai Erera created issue -

          People

          • Assignee:
            Shai Erera
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development