[LUCENE-2338] Some tests catch Exceptions in separate threads and just print a stack trace - the test does not fail

• Type: Test
• Status: Reopened
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: 4.9, 6.0
• Component/s: general/build
• Lucene Fields: New
• Assignee: Uwe Schindler
• Reporter: Uwe Schindler
• Created: 21/Mar/10 16:12
• Updated: 28/Aug/22 12:22

Description

Some tests catch Exceptions in separate threads and just print a stack trace - the test does not fail. The test should fail. Since LUCENE-2274, the LuceneTestCase(J4) class installs an UncaughtExceptionHandler, so this type of catching and solely printing a Stack trace is a bad idea. Problem is, that the run() method of threads is not allowed to throw checked Exceptions.

Two possibilities:

• Catch checked Exceptions in the run() method and wrap into RuntimeException or call Assert.fail() instead
• Use Executors

Issue Links

• requires: LUCENE-2274 Catch exceptions in Threads created by JUnit tasks