Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: core/index
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      I'd like to add a simple and useful MP implementation which does .... nothing ! . I've came across many places where either the following is documented or implemented: "if you want to prevent merges, set mergeFactor to a high enough value". I think a NoOpMergePolicy is just as good, and can REALLY allow you disable merges (except for maybe set mergeFactor to Int.MAX_VAL).

      As such, NoOpMergePolicy will be introduced as a singleton, and can be used for convenience purposes only. Also, for Parallel Index it's important, because I'd like the slices to never do any merges, unless ParallelWriter decides so. So they should be set w/ that MP.

      I have a patch ready. Waiting for LUCENE-2320 to go in, so that I don't need to change it afterwards.

      About the name - I like the name, but suggestions are welcome. I thought of a NullMergePolicy, but I don't like 'Null' used for a NoOp.

      1. LUCENE-2331.patch
        13 kB
        Shai Erera
      2. LUCENE-2331.patch
        13 kB
        Shai Erera
      3. LUCENE-2331.patch
        14 kB
        Shai Erera

        Activity

        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12563457 ] jira [ 12584963 ]
        Mark Thomas made changes -
        Workflow jira [ 12502224 ] Default workflow, editable Closed status [ 12563457 ]
        Michael McCandless made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Shai Erera made changes -
        Attachment LUCENE-2331.patch [ 12439468 ]
        Shai Erera made changes -
        Attachment LUCENE-2331.patch [ 12439452 ]
        Michael McCandless made changes -
        Assignee Michael McCandless [ mikemccand ]
        Shai Erera made changes -
        Field Original Value New Value
        Attachment LUCENE-2331.patch [ 12439337 ]
        Shai Erera created issue -

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development