Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      The parent issue added the functionality to LuceneTestCase(J4), this patch applies it to most tests.

      1. LUCENE-2322.patch
        77 kB
        Uwe Schindler
      2. LUCENE-2322-surround.patch
        3 kB
        Paul Elschot
      3. LUCENE-2322-surround.patch
        2 kB
        Paul Elschot

        Activity

        Hide
        Paul Elschot added a comment -

        This patch removes verbosity from the surround package. With the patch applied, the surround tests have no more stdout.

        Show
        Paul Elschot added a comment - This patch removes verbosity from the surround package. With the patch applied, the surround tests have no more stdout.
        Hide
        Paul Elschot added a comment -

        One should first read the changed code and send the patch. Also removing an unused variable this time.

        Show
        Paul Elschot added a comment - One should first read the changed code and send the patch. Also removing an unused variable this time.
        Hide
        Uwe Schindler added a comment -

        Thanks. I did not change the base classes of surround, only tests. Why was the stuff inside?

        Show
        Uwe Schindler added a comment - Thanks. I did not change the base classes of surround, only tests. Why was the stuff inside?
        Hide
        Paul Elschot added a comment -

        The removed code gives warnings to stdout for cases when a prefixed query term does not expand to any indexed term.
        In case such warnings are needed they can easily be added again, for example to a separate output stream.
        At the time I did not want to introduce a separate warning stream because of the added complexity, but I did need the warnings to verify the tests and the code.

        Show
        Paul Elschot added a comment - The removed code gives warnings to stdout for cases when a prefixed query term does not expand to any indexed term. In case such warnings are needed they can easily be added again, for example to a separate output stream. At the time I did not want to introduce a separate warning stream because of the added complexity, but I did need the warnings to verify the tests and the code.
        Hide
        Uwe Schindler added a comment -

        Committed revision: 923112

        Show
        Uwe Schindler added a comment - Committed revision: 923112

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Uwe Schindler
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development