Lucene - Core
  1. Lucene - Core
  2. LUCENE-2313

Add VERBOSE to LuceneTestCase and LuceneTestCaseJ4

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      component-build.xml allows to define tests.verbose as a system property when running tests. Both LuceneTestCase and LuceneTestCaseJ4 don't read that property. It will be useful for overriding tests to access one place for this setting (I believe currently some tests do it on their own). Then (as a separate issue) we can move all tests that don't check the parameter to only print if VERBOSE is true.

      I will post a patch soon.

        Activity

        Hide
        Shai Erera added a comment -

        Adds VERBOSE to LuceneTestCase and LuceneTestCaseJ4, as well as changes TestQualityRun (contrib/benchmark) to use that. I didn't find any other tests which check that property directly.

        Show
        Shai Erera added a comment - Adds VERBOSE to LuceneTestCase and LuceneTestCaseJ4, as well as changes TestQualityRun (contrib/benchmark) to use that. I didn't find any other tests which check that property directly.
        Hide
        Uwe Schindler added a comment -

        Looks good!

        (I did not even know this property, but we can add this VERBOSE check to more tests, too. The first that come to my mind are NumericRange, Highlighter, Spatial)

        Show
        Uwe Schindler added a comment - Looks good! (I did not even know this property, but we can add this VERBOSE check to more tests, too. The first that come to my mind are NumericRange, Highlighter, Spatial)
        Hide
        Michael McCandless added a comment -

        This is great

        Show
        Michael McCandless added a comment - This is great
        Hide
        Uwe Schindler added a comment -

        Committed revision: 922525

        I only changed the protected to public, to enable helper classes outside util to access the setting.

        Show
        Uwe Schindler added a comment - Committed revision: 922525 I only changed the protected to public, to enable helper classes outside util to access the setting.
        Hide
        Uwe Schindler added a comment -

        As a first test with removed verbosity see revision 922528 (NumericRange tests no longer prints the term statistics per default)

        Show
        Uwe Schindler added a comment - As a first test with removed verbosity see revision 922528 (NumericRange tests no longer prints the term statistics per default)
        Hide
        Shai Erera added a comment -

        I only changed the protected to public, to enable helper classes outside util to access the setting.

        Makes sense Uwe - Thanks ! I went for protected to encourage tests to extend either of the two. Helper classes however are different indeed .

        Show
        Shai Erera added a comment - I only changed the protected to public, to enable helper classes outside util to access the setting. Makes sense Uwe - Thanks ! I went for protected to encourage tests to extend either of the two. Helper classes however are different indeed .

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Shai Erera
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development