Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-2285

Code cleanup from all sorts of (trivial) warnings

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 4.0-ALPHA
    • None
    • None
    • New

    Description

      I would like to do some code cleanup and remove all sorts of trivial warnings, like unnecessary casts, problems w/ javadocs, unused variables, redundant null checks, unnecessary semicolon etc. These are all very trivial and should not pose any problem.

      I'll create another issue for getting rid of deprecated code usage, like LuceneTestCase and all sorts of deprecated constructors. That's also trivial because it only affects Lucene code, but it's a different type of change.

      Another issue I'd like to create is about introducing more generics in the code, where it's missing today - not changing existing API. There are many places in the code like that.

      So, with you permission, I'll start with the trivial ones first, and then move on to the others.

      Attachments

        1. LUCENE-2285.patch
          524 kB
          Uwe Schindler
        2. LUCENE-2285.patch
          755 kB
          Shai Erera
        3. LUCENE-2285.patch
          754 kB
          Shai Erera
        4. LUCENE-2285-remaining.patch
          10 kB
          Uwe Schindler
        5. LUCENE-2285-remaining+generated.patch
          232 kB
          Uwe Schindler

        Issue Links

          Activity

            People

              uschindler Uwe Schindler
              shaie Shai Erera
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: