Lucene - Core
  1. Lucene - Core
  2. LUCENE-2243

FastVectorHighlighter: support DisjunctionMaxQuery

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9, 2.9.1, 3.0
    • Fix Version/s: 4.0-ALPHA
    • Component/s: modules/highlighter
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Add DisjunctionMaxQuery support in FVH.

      1. LUCENE-2243.patch
        4 kB
        Koji Sekiguchi

        Issue Links

          Activity

          Koji Sekiguchi created issue -
          Koji Sekiguchi made changes -
          Field Original Value New Value
          Link This issue is related to LUCENE-1889 [ LUCENE-1889 ]
          Hide
          Koji Sekiguchi added a comment -

          The fix attached. I'll commit later today.

          Show
          Koji Sekiguchi added a comment - The fix attached. I'll commit later today.
          Koji Sekiguchi made changes -
          Attachment LUCENE-2243.patch [ 12431854 ]
          Hide
          Simon Willnauer added a comment -

          Koji, could you use a foreach loop instead of the iterator... just my 0.02$

                      DisjunctionMaxQuery dmq = (DisjunctionMaxQuery)sourceQuery;
                      for (Query query : dmq) {
                        flatten(query, flatQueries);
                      }
          

          simon

          Show
          Simon Willnauer added a comment - Koji, could you use a foreach loop instead of the iterator... just my 0.02$ DisjunctionMaxQuery dmq = (DisjunctionMaxQuery)sourceQuery; for (Query query : dmq) { flatten(query, flatQueries); } simon
          Hide
          Koji Sekiguchi added a comment -

          Koji, could you use a foreach loop instead of the iterator... just my 0.02$

          Sure. Committed revision 904776.

          Show
          Koji Sekiguchi added a comment - Koji, could you use a foreach loop instead of the iterator... just my 0.02$ Sure. Committed revision 904776.
          Koji Sekiguchi made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Mark Thomas made changes -
          Workflow jira [ 12489769 ] Default workflow, editable Closed status [ 12563415 ]
          Mark Thomas made changes -
          Workflow Default workflow, editable Closed status [ 12563415 ] jira [ 12584559 ]
          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          13h 11m 1 Koji Sekiguchi 30/Jan/10 13:14
          Resolved Resolved Closed Closed
          1195d 21h 29m 1 Uwe Schindler 10/May/13 11:44

            People

            • Assignee:
              Unassigned
              Reporter:
              Koji Sekiguchi
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development