Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-2241

Core Tests should call Version based ctors instead of deprecated default ctors

        Details

        • Type: Task
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: 3.1
        • Fix Version/s: 4.0-ALPHA
        • Component/s: modules/analysis
        • Labels:
          None
        • Lucene Fields:
          New, Patch Available

          Description

          LUCENE-2183 introduced new ctors for all CharTokenizer subclasses. Core - tests should use those ctors with Version.LUCENE_CURRENT instead of the the deprecated ctors. Yet, LUCENE-2240 introduces more Version ctors For WhitespaceAnalyzer and SimpleAnalyzer. Test should also use their Version ctors instead the default ones.

          1. Text File
            LUCENE-2241.patch
            245 kB
            Simon Willnauer

            Issue Links

            is blocked by

            Task - A task that needs to be done. LUCENE-2240 SimpleAnalyzer and WhitespaceAnalyzer should have Version ctors

            • Minor - Minor loss of function, or other problem where easy workaround is present.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              simonw Simon Willnauer added a comment -

              this is block by LUCENE-2240

              Show
              simonw Simon Willnauer added a comment - this is block by LUCENE-2240
              Hide
              Permalink
              simonw Simon Willnauer added a comment -

              converted all core tests to use Version ctors

              Show
              simonw Simon Willnauer added a comment - converted all core tests to use Version ctors
              Hide
              Permalink
              thetaphi Uwe Schindler added a comment -

              Patch looks good, I will commit this with LUCENE-2240 in a day or two.

              Show
              thetaphi Uwe Schindler added a comment - Patch looks good, I will commit this with LUCENE-2240 in a day or two.
              Hide
              Permalink
              thetaphi Uwe Schindler added a comment -

              Committed revision: 905044

              Thanks Simon!

              Show
              thetaphi Uwe Schindler added a comment - Committed revision: 905044 Thanks Simon!

                People

                • Assignee:
                  thetaphi Uwe Schindler
                  Reporter:
                  simonw Simon Willnauer
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development