Lucene - Core
  1. Lucene - Core
  2. LUCENE-2240

SimpleAnalyzer and WhitespaceAnalyzer should have Version ctors

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 4.0-ALPHA
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      Due to the Changes to CharTokenizer ( LUCENE-2183 ) WhitespaceAnalyzer and SimpleAnalyzer need a Version ctor. Default ctors must be deprecated

      1. LUCENE-2240.patch
        4 kB
        Simon Willnauer

        Issue Links

          Activity

          Hide
          Simon Willnauer added a comment -

          This patch add the new Version ctors and deprecates the defaiult ctor. I did not change any references as I want to split those up in smaller issues. I already changed all references which resulted in a 400k patch. We should rather do it step by step.

          Show
          Simon Willnauer added a comment - This patch add the new Version ctors and deprecates the defaiult ctor. I did not change any references as I want to split those up in smaller issues. I already changed all references which resulted in a 400k patch. We should rather do it step by step.
          Hide
          Uwe Schindler added a comment -

          Patch looks good, I will commit this with LUCENE-2241 in a day or two.

          Show
          Uwe Schindler added a comment - Patch looks good, I will commit this with LUCENE-2241 in a day or two.
          Hide
          Simon Willnauer added a comment -

          Patch looks good, I will commit this with LUCENE-2241 in a day or two.

          cool, I will go on with LUCENE-2242 and rest of contrib once this is committed

          Show
          Simon Willnauer added a comment - Patch looks good, I will commit this with LUCENE-2241 in a day or two. cool, I will go on with LUCENE-2242 and rest of contrib once this is committed
          Hide
          Uwe Schindler added a comment -

          Committed revision: 905044

          Thanks Simon!

          Show
          Uwe Schindler added a comment - Committed revision: 905044 Thanks Simon!

            People

            • Assignee:
              Uwe Schindler
              Reporter:
              Simon Willnauer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development