Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-2200

Several final classes have non-overriding protected members

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 3.0
    • 4.0-ALPHA
    • None
    • None
    • New, Patch Available

    Description

      Protected member access in final classes, except where a protected method overrides a superclass's protected method, makes little sense. The attached patch converts final classes' protected access on fields to private, removes two final classes' unused protected constructors, and converts one final class's protected final method to private.

      Attachments

        1. LUCENE-2200.patch
          7 kB
          Steven Rowe
        2. LUCENE-2200.patch
          6 kB
          Steven Rowe
        3. LUCENE-2200.patch
          6 kB
          Steven Rowe

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            rcmuir Robert Muir
            sarowe Steven Rowe
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment