Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      snowball stemming currently creates 2 new strings and 1 new stringbuilder for every word.

      all of this is unnecessary, so don't do it.

        Activity

        Hide
        Robert Muir added a comment -

        trivial patch, i left the string-based stuff alone (even though it could be improved) since we no longer use them with this patch.

        Show
        Robert Muir added a comment - trivial patch, i left the string-based stuff alone (even though it could be improved) since we no longer use them with this patch.
        Hide
        Robert Muir added a comment -

        i tested this with some English, benchmark pkg, etc and at most it seems to only improve processing speed 10%. but I think its worth the trouble since its an easy improvement.

        i'll commit in a few days if no one objects.

        Show
        Robert Muir added a comment - i tested this with some English, benchmark pkg, etc and at most it seems to only improve processing speed 10%. but I think its worth the trouble since its an easy improvement. i'll commit in a few days if no one objects.
        Hide
        Simon Willnauer added a comment -

        looks good robert. Nice improvement.

        Show
        Simon Willnauer added a comment - looks good robert. Nice improvement.
        Hide
        Robert Muir added a comment -

        Committed revision 897449.

        Show
        Robert Muir added a comment - Committed revision 897449.

          People

          • Assignee:
            Robert Muir
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development