Lucene - Core
  1. Lucene - Core
  2. LUCENE-2191

rename Tokenizer.reset(Reader) to Tokenizer.setReader(Reader)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-BETA, 5.0
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      in TokenStream there is a reset() method, but the method in Tokenizer used to set a new Reader is called reset(Reader).

      in my opinion this name overloading creates a lot of confusion, and we see things like reset(Reader) calling reset() even in StandardTokenizer...

      So I think this would be some work to fulfill all the backwards compatibility, but worth it because when you look at the existing reset(Reader) and reset() code in various tokenizers, or the javadocs for Tokenizer, its pretty confusing and inconsistent.

      1. LUCENE-2191.patch
        25 kB
        Robert Muir
      2. LUCENE-2191.patch
        23 kB
        Robert Muir

        Issue Links

          Activity

          Robert Muir created issue -
          Uwe Schindler made changes -
          Field Original Value New Value
          Link This issue depends on LUCENE-2188 [ LUCENE-2188 ]
          Robert Muir made changes -
          Component/s contrib/analyzers [ 12312333 ]
          Component/s Analysis [ 12310230 ]
          Uwe Schindler made changes -
          Fix Version/s 4.0 [ 12314025 ]
          Mark Thomas made changes -
          Workflow jira [ 12485934 ] Default workflow, editable Closed status [ 12563559 ]
          Mark Thomas made changes -
          Workflow Default workflow, editable Closed status [ 12563559 ] jira [ 12585152 ]
          Shai Erera made changes -
          Component/s contrib/analyzers [ 12312333 ]
          Component/s modules/analysis [ 12310230 ]
          Robert Muir made changes -
          Attachment LUCENE-2191.patch [ 12501864 ]
          Robert Muir made changes -
          Fix Version/s 4.1 [ 12321140 ]
          Fix Version/s 4.0 [ 12314025 ]
          Robert Muir made changes -
          Attachment LUCENE-2191.patch [ 12536582 ]
          Robert Muir made changes -
          Fix Version/s 4.0 [ 12322456 ]
          Fix Version/s 5.0 [ 12321663 ]
          Fix Version/s 4.1 [ 12321140 ]
          Robert Muir made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Gavin made changes -
          Link This issue depends on LUCENE-2188 [ LUCENE-2188 ]
          Gavin made changes -
          Link This issue depends upon LUCENE-2188 [ LUCENE-2188 ]
          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development