[LUCENE-2191] rename Tokenizer.reset(Reader) to Tokenizer.setReader(Reader)

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 4.0-BETA, 6.0
• Component/s: modules/analysis
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Robert Muir
• Created: 04/Jan/10 12:03
• Updated: 28/Aug/22 12:18
• Resolved: 16/Jul/12 15:20

Description

in TokenStream there is a reset() method, but the method in Tokenizer used to set a new Reader is called reset(Reader).

in my opinion this name overloading creates a lot of confusion, and we see things like reset(Reader) calling reset() even in StandardTokenizer...

So I think this would be some work to fulfill all the backwards compatibility, but worth it because when you look at the existing reset(Reader) and reset() code in various tokenizers, or the javadocs for Tokenizer, its pretty confusing and inconsistent.

Issue Links

• depends upon: LUCENE-2188 A handy utility class for tracking deprecated overridden methods