[LUCENE-2171] Over synchronization for read-only index readers in SegmentTermDocs

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.9.1, 3.0
• Fix Version/s: 4.9, 6.0
• Component/s: core/search
• Labels: dead
• Lucene Fields: New
• Assignee: Unassigned
• Reporter: Jayson Minard
• Created: 18/Dec/09 18:18
• Updated: 28/Aug/22 12:17

Description

In SegmentTermDocs constructor (from 2.9.1)

46	  protected SegmentTermDocs(SegmentReader parent) {
47	    this.parent = parent;
48	    this.freqStream = (IndexInput) parent.core.freqStream.clone();
49	    synchronized (parent) {
50	      this.deletedDocs = parent.deletedDocs;
51	    }
52	    this.skipInterval = parent.core.getTermsReader().getSkipInterval();
53	    this.maxSkipLevels = parent.core.getTermsReader().getMaxSkipLevels();
54	  }

The synchronization on "parent" for accessing deletedDocs is unnecessary on readonly indexes. If that access was moved into the SegmentReader then it could be protected there by default and overridden in ReadonlySegmentReader.