Lucene - Core
  1. Lucene - Core
  2. LUCENE-2157

DelimitedPayloadTokenFilter copies the bufer over itsself. Instead it should only set the length. Also optimize logic.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0
    • Fix Version/s: 4.0-ALPHA
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      This is a small improvement I found when looking around. It is also a bad idea to copy a array over itsself.

      All tests pass, will commit later!

      1. LUCENE-2157.patch
        2 kB
        Uwe Schindler
      2. LUCENE-2157.patch
        4 kB
        Uwe Schindler
      3. LUCENE-2157.patch
        4 kB
        Uwe Schindler

        Activity

        Uwe Schindler created issue -
        Uwe Schindler made changes -
        Field Original Value New Value
        Attachment LUCENE-2157.patch [ 12427944 ]
        Hide
        Uwe Schindler added a comment -

        Now an even optimized IdentityEncode for payloads. It uses ByteBuffer and CharBuffer to encode. Can anybody with more NIO knowledge review this?

        Show
        Uwe Schindler added a comment - Now an even optimized IdentityEncode for payloads. It uses ByteBuffer and CharBuffer to encode. Can anybody with more NIO knowledge review this?
        Uwe Schindler made changes -
        Attachment LUCENE-2157.patch [ 12427956 ]
        Hide
        Uwe Schindler added a comment -

        Final patch, will commit this soon. I verified, that the code is correct accoring to NIO CharsetEncoder.encode()

        Show
        Uwe Schindler added a comment - Final patch, will commit this soon. I verified, that the code is correct accoring to NIO CharsetEncoder.encode()
        Uwe Schindler made changes -
        Attachment LUCENE-2157.patch [ 12428040 ]
        uschindler committed 890791 (3 files)
        Reviews: none

        LUCENE-2157: DelimitedPayloadTokenFilter no longer copies the buffer over itsself, instead it sets the length to the offset of the delimiter. Also optimizes logic and IdentityEncoder to use NIO.

        Hide
        Uwe Schindler added a comment -

        Committed revision: 890791

        Show
        Uwe Schindler added a comment - Committed revision: 890791
        Uwe Schindler made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Mark Thomas made changes -
        Workflow jira [ 12484648 ] Default workflow, editable Closed status [ 12562943 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12562943 ] jira [ 12583822 ]
        Shai Erera made changes -
        Component/s modules/analysis [ 12310230 ]
        Component/s contrib/analyzers [ 12312333 ]
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Uwe Schindler
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development