Lucene - Core
  1. Lucene - Core
  2. LUCENE-2137

Replace SegmentReader.Ref with AtomicInteger

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      I think the patch should be applied to backcompat tag in its entirety.

      1. LUCENE-2137.patch
        12 kB
        Earwin Burrfoot

        Activity

        Hide
        Uwe Schindler added a comment -

        I backwards branch we should only change tests (as we want to test if a drop-in replacement still works). But never change the src/java folder in BW. So the only option in BW is to comment out that tests, as running them will fail. The functionality is tested by the trunk tests.

        Else +1, its rather straightforward; I should have seen this during the Lucene 3.0 police audition

        Show
        Uwe Schindler added a comment - I backwards branch we should only change tests (as we want to test if a drop-in replacement still works). But never change the src/java folder in BW. So the only option in BW is to comment out that tests, as running them will fail. The functionality is tested by the trunk tests. Else +1, its rather straightforward; I should have seen this during the Lucene 3.0 police audition
        Hide
        Michael McCandless added a comment -

        I'll remove/comment out the affected back-compat tests.

        Show
        Michael McCandless added a comment - I'll remove/comment out the affected back-compat tests.
        Hide
        Michael McCandless added a comment -

        Thanks Earwin!

        Show
        Michael McCandless added a comment - Thanks Earwin!

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Earwin Burrfoot
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development