Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-2114

Improve org.apache.lucene.search.Filter Documentation and Tests to reflect per segment readers

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 2.9, 2.9.1, 3.0
        • Fix Version/s: 2.9.2, 3.0.1, 4.0-ALPHA
        • Component/s: core/search
        • Labels:
          None
        • Lucene Fields:
          New, Patch Available

          Description

          Filter Javadoc does not mention that the Reader passed to getDocIDSet(Reader) could be on a per-segment basis.
          This caused confusion on the users-list – see http://lucene.markmail.org/message/6knz2mkqbpxjz5po?q=date:200912+list:org.apache.lucene.java-user&page=1
          We should improve the javadoc and also add a testcase that reflects filtering on a per-segment basis.

          1. Text File
            LUCENE-2114.patch
            5 kB
            Simon Willnauer

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            simonw Simon Willnauer added a comment -

            Attached a patch that improves the javadoc and modifies the TestFilteredSearch test to pass segment readers to getDocIdSet

            Show
            simonw Simon Willnauer added a comment - Attached a patch that improves the javadoc and modifies the TestFilteredSearch test to pass segment readers to getDocIdSet
            Hide
            Permalink
            mikemccand Michael McCandless added a comment -

            Looks good, I'll commit shortly – thanks Simon!

            Show
            mikemccand Michael McCandless added a comment - Looks good, I'll commit shortly – thanks Simon!
            Hide
            Permalink
            mikemccand Michael McCandless added a comment -

            Thanks Simon!

            Show
            mikemccand Michael McCandless added a comment - Thanks Simon!
            Hide
            Permalink
            mikemccand Michael McCandless added a comment -

            Need to backport to 2.9.x, 3.0.x....

            Show
            mikemccand Michael McCandless added a comment - Need to backport to 2.9.x, 3.0.x....

              People

              • Assignee:
                Unassigned
                Reporter:
                simonw Simon Willnauer
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development