[LUCENE-2104] IndexWriter.unlock does does nothing if NativeFSLockFactory is used

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.9, 2.9.1, 3.0
• Fix Version/s: 2.9.3, 3.0.2, 3.1, 4.0-ALPHA
• Component/s: core/store
• Lucene Fields: New, Patch Available
• Assignee: Uwe Schindler
• Reporter: Shai Erera
• Created: 02/Dec/09 15:35
• Updated: 28/Aug/22 12:15
• Resolved: 01/Jun/10 18:36

Description

If NativeFSLockFactory is used, IndexWriter.unlock will return, silently doing nothing. The reason is that NativeFSLockFactory's makeLock always creates a new NativeFSLock. NativeFSLock's release first checks if its lock is not null. However, only if obtain() is called, that lock is not null. So release actually does nothing, and so IndexWriter.unlock does not delete the lock, or fail w/ exception.
This is only a problem in NativeFSLock, and not in other Lock implementations, at least as I was able to see.

Need to think first how to reproduce in a test, and then fix it. I'll work on it.