[LUCENE-2103] NoLockFactory should have a private constructor

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.0
• Fix Version/s: 4.0-ALPHA
• Component/s: core/store
• Lucene Fields: New, Patch Available
• Assignee: Uwe Schindler
• Reporter: Shai Erera
• Created: 02/Dec/09 14:05
• Updated: 28/Aug/22 12:15
• Resolved: 07/Dec/09 16:50

Description

NoLockFactory documents in its javadocs that one should use the static getNoLockFactory() method. However the class does not declare a private empty constructor, which breaks its Singleton purpose. We cannot add the empty private constructor because that'd break break-compat (even though I think it's very low chance someone actually instantiates the class), therefore we'll add a @deprecated warning to the class about this, and add the method in 4.0. I personally prefer to add an empty constructor w/ the @deprecated method, but am fine either way.

Don't know if a patch is needed, as this is a trivial change.