Lucene - Core
  1. Lucene - Core
  2. LUCENE-2087

Remove recursion in NumericRangeTermEnum

        Details

        • Type: Improvement Improvement
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.9, 2.9.1, 3.0
        • Fix Version/s: 3.0, 4.0-ALPHA
        • Component/s: core/search
        • Labels:
          None
        • Lucene Fields:
          New, Patch Available

          Description

          The current FilteredTermEnum in NRQ uses setEnum() which itsself calls next(). This may lead to a recursion that can overflow stack, if the index is empty and a large range with low precStep is used. With 64 bit numbers and precStep == 1 there may be 127 recursions, as each sub-range would hit no term on empty index and the setEnum call would then call next() which itsself calls setEnum again. This leads to recursion depth of 256.

          Attached is a patch that converts to iterative approach. setEnum is now unused and throws UOE (like endEnum()).

          1. Text File
            LUCENE-2087.patch
            3 kB
            Uwe Schindler

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Uwe Schindler added a comment -

            I will commit this soon.

            Show
            Uwe Schindler added a comment - I will commit this soon.
            Hide
            Permalink
            Uwe Schindler added a comment -

            Committed revision: 882977

            Show
            Uwe Schindler added a comment - Committed revision: 882977

              People

              • Assignee:
                Uwe Schindler
                Reporter:
                Uwe Schindler
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development