[LUCENE-2064] Highlighter should support all MultiTermQuery subclasses without casts

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.9.1
• Fix Version/s: 3.0
• Component/s: modules/highlighter
• Lucene Fields: New, Patch Available
• Assignee: Simon Willnauer
• Reporter: Simon Willnauer
• Created: 13/Nov/09 20:48
• Updated: 28/Aug/22 12:14
• Resolved: 14/Nov/09 12:26

Description

In order to support MultiTermQuery subclasses the Highlighter component applies instanceof checks for concrete classes from the lucene core. This prevents classes like RegexQuery in contrib from being supported. Introducing dependencies on other contribs is not feasible just for being supported by the highlighter.

While the instanceof checks and subsequent casts might hopefully go somehow away in the future but for supporting more multterm queries I have a alternative approach using a fake IndexReader that uses a RewriteMethod to force the MTQ to pass the field name to the given reader without doing any real work. It is easier to explain once you see the patch - I will upload shortly.

Issue Links

• is depended upon by: LUCENE-2066 Add Highlighter test for RegexQuery