[LUCENE-2057] TopDocsCollector should have bounded generic <T extends ScoreDoc>

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0
• Component/s: core/search
• Lucene Fields: New
• Assignee: Uwe Schindler
• Reporter: Shai Erera
• Created: 11/Nov/09 19:49
• Updated: 28/Aug/22 12:13
• Resolved: 11/Nov/09 21:58

Description

TopDocsCollector was changed to be TopDocsCollector<T>. However it has methods which specifically assume the PQ stores ScoreDoc. Therefore, if someone extends it and defines a type which is not ScoreDoc, things will break.

We shouldn't put <T> on TopDocsCollector at all, but rather change its ctor to protected TopDocsCollector(PriorityQueue<? extends ScoreDoc> pq). TopDocsCollector should handle ScoreDoc types. If we do this, we'll need to change FieldValueHitQueue's Entry to extend ScoreDoc as well.