Lucene - Core
  1. Lucene - Core
  2. LUCENE-2051

Contrib Analyzer Setters should be deprecated and replace with ctor arguments

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9.1
    • Fix Version/s: 3.0
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Some analyzers in contrib provide setters for stopword / stem exclusion sets / hashtables etc. Those setters should be deprecated as they yield unexpected behaviour. The way they work is they set the reusable token stream instance to null in a thread local cache which only affects the tokenstream in the current thread. Analyzers itself should be immutable except of the threadlocal.

      will attach a patch soon.

      1. LUCENE-2051.patch
        44 kB
        Simon Willnauer
      2. LUCENE-2051.patch
        36 kB
        Simon Willnauer

        Issue Links

          Activity

          Simon Willnauer created issue -
          Simon Willnauer made changes -
          Field Original Value New Value
          Assignee Simon Willnauer [ simonw ]
          Simon Willnauer made changes -
          Attachment LUCENE-2051.patch [ 12425016 ]
          Simon Willnauer made changes -
          Link This issue is related to LUCENE-2034 [ LUCENE-2034 ]
          Simon Willnauer made changes -
          Attachment LUCENE-2051.patch [ 12425033 ]
          Simon Willnauer made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Uwe Schindler made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Mark Thomas made changes -
          Workflow jira [ 12481698 ] Default workflow, editable Closed status [ 12563228 ]
          Mark Thomas made changes -
          Workflow Default workflow, editable Closed status [ 12563228 ] jira [ 12584300 ]
          Shai Erera made changes -
          Component/s modules/analysis [ 12310230 ]
          Component/s contrib/analyzers [ 12312333 ]

            People

            • Assignee:
              Simon Willnauer
              Reporter:
              Simon Willnauer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development