Lucene - Core
  1. Lucene - Core
  2. LUCENE-2043

Fix CommitIndexTask to also commit IndexReader changes

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Component/s: modules/benchmark
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      I'm setting up a benchmark for LUCENE-1458, and one limitation I hit is that the CommitIndexTask doesn't commit pending changes in the IndexReader (eg via DeleteByPercent), using a named commit point.

      1. LUCENE-2043.patch
        3 kB
        Michael McCandless

        Activity

        Hide
        Michael McCandless added a comment -

        Simple patch.

        Though, I changed IndexReader.commit(Map<String,String>) from protected to public; I'm not sure why we made it protected on the first go.

        Show
        Michael McCandless added a comment - Simple patch. Though, I changed IndexReader.commit(Map<String,String>) from protected to public; I'm not sure why we made it protected on the first go.

          People

          • Assignee:
            Michael McCandless
            Reporter:
            Michael McCandless
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development