Lucene - Core
  1. Lucene - Core
  2. LUCENE-2039

Regex support and beyond in JavaCC QueryParser

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-ALPHA, 4.0
    • Component/s: core/queryparser
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Since the early days the standard query parser was limited to the queries living in core, adding other queries or extending the parser in any way always forced people to change the grammar file and regenerate. Even if you change the grammar you have to be extremely careful how you modify the parser so that other parts of the standard parser are affected by customisation changes. Eventually you had to live with all the limitation the current parser has like tokenizing on whitespaces before a tokenizer / analyzer has the chance to look at the tokens.
      I was thinking about how to overcome the limitation and add regex support to the query parser without introducing any dependency to core. I added a new special character that basically prevents the parser from interpreting any of the characters enclosed in the new special characters. I choose the forward slash '/' as the delimiter so that everything in between two forward slashes is basically escaped and ignored by the parser. All chars embedded within forward slashes are treated as one token even if it contains other special chars like * []?{} or whitespaces. This token is subsequently passed to a pluggable "parser extension" with builds a query from the embedded string. I do not interpret the embedded string in any way but leave all the subsequent work to the parser extension. Such an extension could be another full featured query parser itself or simply a ctor call for regex query. The interface remains quiet simple but makes the parser extendible in an easy way compared to modifying the javaCC sources.

      The downsides of this patch is clearly that I introduce a new special char into the syntax but I guess that would not be that much of a deal as it is reflected in the escape method though. It would truly be nice to have more than once extension an have this even more flexible so treat this patch as a kickoff though.

      Another way of solving the problem with RegexQuery would be to move the JDK version of regex into the core and simply have another method like:

      protected Query newRegexQuery(Term t) {
        ... 
      }
      

      which I would like better as it would be more consistent with the idea of the query parser to be a very strict and defined parser.

      I will upload a patch in a second which implements the extension based approach I guess I will add a second patch with regex in core soon too.

      1. LUCENE-2039.patch
        19 kB
        Simon Willnauer
      2. LUCENE-2039_wrap_master_parser.patch
        2 kB
        Simon Willnauer
      3. LUCENE-2039_field_ext.patch
        37 kB
        Simon Willnauer
      4. LUCENE-2039_field_ext.patch
        38 kB
        Simon Willnauer
      5. LUCENE-2039_field_ext.patch
        38 kB
        Simon Willnauer
      6. LUCENE-2039_field_ext.patch
        44 kB
        Simon Willnauer
      7. LUCENE-2039_field_ext.patch
        33 kB
        Simon Willnauer

        Issue Links

          Activity

          No work has yet been logged on this issue.

            People

            • Assignee:
              Simon Willnauer
              Reporter:
              Simon Willnauer
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development