Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Component/s: modules/other
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      there aren't too many deprecations in contrib to remove for 3.0, but we should get rid of them.

      1. LUCENE_2022_analysis_wikipedia.patch
        5 kB
        Robert Muir
      2. LUCENE-2022.patch
        23 kB
        Robert Muir
      3. LUCENE-2022.patch
        24 kB
        Robert Muir
      4. LUCENE-2022.patch
        24 kB
        Robert Muir

        Activity

        Hide
        Robert Muir added a comment -

        Committed revision 834707.

        Show
        Robert Muir added a comment - Committed revision 834707.
        Hide
        Simon Willnauer added a comment -

        I will commit this one soon.

        +1 looks good to me!

        Show
        Simon Willnauer added a comment - I will commit this one soon. +1 looks good to me!
        Hide
        Robert Muir added a comment -

        Uwe, I will check/comment under your LUCENE-1980 issue, there shouldn't be too many issues not much was deprecated in contrib.

        I will commit this one soon.

        Show
        Robert Muir added a comment - Uwe, I will check/comment under your LUCENE-1980 issue, there shouldn't be too many issues not much was deprecated in contrib. I will commit this one soon.
        Hide
        Uwe Schindler added a comment -

        +1

        I am currently fixing core's javadocs (LUCENE-1980). Can you check contrib?

        Show
        Uwe Schindler added a comment - +1 I am currently fixing core's javadocs ( LUCENE-1980 ). Can you check contrib?
        Hide
        Robert Muir added a comment -

        btw i found the javadocs typo of

        @deprecated Use {@link #TextFragment(CharSequence, int, int)} instead.
        

        i'll correct this, i think everything else is ok though.

        Show
        Robert Muir added a comment - btw i found the javadocs typo of @deprecated Use {@link #TextFragment(CharSequence, int, int)} instead. i'll correct this, i think everything else is ok though.
        Hide
        Robert Muir added a comment -

        attached is a patch that changes the javadocs for the spatial class to 'will be removed in a future release', since it is experimental.

        if no one objects i would like to resolve this issue soon, it would be nice if someone could at least give a quick review, make me feel more comfortable

        Show
        Robert Muir added a comment - attached is a patch that changes the javadocs for the spatial class to 'will be removed in a future release', since it is experimental. if no one objects i would like to resolve this issue soon, it would be nice if someone could at least give a quick review, make me feel more comfortable
        Hide
        Robert Muir added a comment -

        Ryan, do you think it is best to just remove this class instead?

        Show
        Robert Muir added a comment - Ryan, do you think it is best to just remove this class instead?
        Hide
        Ryan McKinley added a comment -

        For:

        also add a "will be removed in 4.0" to the deprecated DistanceApproximation in spatial

        I think/hope spatial is marked as 'experimental' – there should be no commitment to hang on to APIs until 4.0... who knows how far off that is!

        When spatial gets some attention, there should be more flexibility to design things as best they can be.

        Show
        Ryan McKinley added a comment - For: also add a "will be removed in 4.0" to the deprecated DistanceApproximation in spatial I think/hope spatial is marked as 'experimental' – there should be no commitment to hang on to APIs until 4.0... who knows how far off that is! When spatial gets some attention, there should be more flexibility to design things as best they can be.
        Hide
        Robert Muir added a comment -

        also add a "will be removed in 4.0" to the deprecated DistanceApproximation in spatial

        Show
        Robert Muir added a comment - also add a "will be removed in 4.0" to the deprecated DistanceApproximation in spatial
        Hide
        Robert Muir added a comment -

        patch to remove the rest of the 2.9 deprecations.
        any 3.0 deprecations (except the ones from javacc generated code) are marked with "will be removed in 4.0" as well for now.

        Show
        Robert Muir added a comment - patch to remove the rest of the 2.9 deprecations. any 3.0 deprecations (except the ones from javacc generated code) are marked with "will be removed in 4.0" as well for now.
        Hide
        Robert Muir added a comment -

        Committed revision 831425 (LUCENE_2022_analysis_wikipedia.patch).

        Show
        Robert Muir added a comment - Committed revision 831425 (LUCENE_2022_analysis_wikipedia.patch).
        Hide
        Robert Muir added a comment -

        i think this analysis stuff is obvious. I will commit it soon.

        if anyone wants to jump in and look at the other deprecations (contrib/misc, queries, etc) please do

        Show
        Robert Muir added a comment - i think this analysis stuff is obvious. I will commit it soon. if anyone wants to jump in and look at the other deprecations (contrib/misc, queries, etc) please do
        Hide
        Robert Muir added a comment -

        patch for analysis and wikipedia (the ones i feel comfortable about)

        Show
        Robert Muir added a comment - patch for analysis and wikipedia (the ones i feel comfortable about)

          People

          • Assignee:
            Robert Muir
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development