Lucene - Core
  1. Lucene - Core
  2. LUCENE-2021

French elision filter should use CharArraySet

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      French elision filter creates new strings, lowercases them, etc just to check against a Set<String>.
      trivial patch to use chararrayset instead.

      1. LUCENE-2021.patch
        3 kB
        Robert Muir
      2. LUCENE-2021.patch
        3 kB
        Robert Muir

        Activity

        Hide
        Uwe Schindler added a comment -

        The setArticles method could check with instanceof, if the supplied set is a chararrayset and use it directly (see StopFilter). Otherwise looks good.

        Show
        Uwe Schindler added a comment - The setArticles method could check with instanceof, if the supplied set is a chararrayset and use it directly (see StopFilter). Otherwise looks good.
        Hide
        Robert Muir added a comment -

        The setArticles method could check with instanceof, if the supplied set is a chararrayset and use it directly (see StopFilter). Otherwise looks good.

        good idea, I'll fix this.

        Show
        Robert Muir added a comment - The setArticles method could check with instanceof, if the supplied set is a chararrayset and use it directly (see StopFilter). Otherwise looks good. good idea, I'll fix this.
        Hide
        Robert Muir added a comment -

        do not create a new chararrayset in setArticles if the supplied set is already a chararrayset.

        Show
        Robert Muir added a comment - do not create a new chararrayset in setArticles if the supplied set is already a chararrayset.
        Hide
        Robert Muir added a comment -

        Committed revision 831268.

        Show
        Robert Muir added a comment - Committed revision 831268.

          People

          • Assignee:
            Robert Muir
            Reporter:
            Robert Muir
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development