Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.9
    • Fix Version/s: 3.0
    • Component/s: core/query/scoring
    • Labels:
      None
    • Lucene Fields:
      New, Patch Available

      Description

      DisjunctionMaxQuery code has containers that are not type-safe . The comments indicate type-safety though.

      Better to express in the API and the internals the explicit type as opposed to type-less containers.

      Patch attached.

      Comments / backward compatibility concerns welcome.

      1. LUCENE-1984.patch
        11 kB
        Uwe Schindler
      2. LUCENE-1984.patch
        4 kB
        Karthik K

        Issue Links

          Activity

          Hide
          Uwe Schindler added a comment -

          We are converting a lot of these containers to generics currently for Lucene 3.0. In 2.9, we are limited to Java 1.4

          Show
          Uwe Schindler added a comment - We are converting a lot of these containers to generics currently for Lucene 3.0. In 2.9, we are limited to Java 1.4
          Hide
          Karthik K added a comment -

          Great - Thanks.

          For the sake of continuity - which branch would this ( Lucene 3.0 ) be located in .

          Having said that - then I believe this can be closed as redundant.

          Show
          Karthik K added a comment - Great - Thanks. For the sake of continuity - which branch would this ( Lucene 3.0 ) be located in . Having said that - then I believe this can be closed as redundant.
          Hide
          Uwe Schindler added a comment -

          3.0 is currently trunk. 2.9 is a branch.

          Please leave it open, as I am not yet finished with converting to generics. LUCENE-1257 is the main issue for Java 5.

          Show
          Uwe Schindler added a comment - 3.0 is currently trunk. 2.9 is a branch. Please leave it open, as I am not yet finished with converting to generics. LUCENE-1257 is the main issue for Java 5.
          Hide
          Uwe Schindler added a comment -

          Small updates in Patch (also implemented Iterable). I also generified the other Disjunction classes.

          Will commit soon. Thanks Kay Kay!

          Show
          Uwe Schindler added a comment - Small updates in Patch (also implemented Iterable). I also generified the other Disjunction classes. Will commit soon. Thanks Kay Kay!
          Hide
          Uwe Schindler added a comment -

          Committed revision: 825881

          Thanks Kay Kay!

          Show
          Uwe Schindler added a comment - Committed revision: 825881 Thanks Kay Kay!
          Hide
          Karthik K added a comment -

          Thanks Uwe. The revised patch looks good as well, with better code readability.

          Show
          Karthik K added a comment - Thanks Uwe. The revised patch looks good as well, with better code readability.
          Hide
          Karthik K added a comment -

          As a related patch - LUCENE-1985 added to improve readability to convert Iterable<?> statements to for loops introduced in java 5

          Show
          Karthik K added a comment - As a related patch - LUCENE-1985 added to improve readability to convert Iterable<?> statements to for loops introduced in java 5

            People

            • Assignee:
              Uwe Schindler
              Reporter:
              Karthik K
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development