Lucene - Core
  1. Lucene - Core
  2. LUCENE-1972

Remove (deprecated) ExtendedFieldCache and Auto/Custom caches and lot's of deprecated sort logic

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Remove (deprecated) ExtendedFieldCache and Auto/Custom caches and sort

      1. LUCENE-1972.patch
        107 kB
        Uwe Schindler
      2. LUCENE-1972-2.patch
        5 kB
        Uwe Schindler
      3. LUCENE-1972-bw.patch
        18 kB
        Uwe Schindler
      4. LUCENE-1972-fix.patch
        1 kB
        Uwe Schindler

        Activity

        Hide
        Uwe Schindler added a comment -

        This patch removes ExtendedFieldCache bw layer. It also removes the AUTO and CUSTOM caches.

        Because of that, also lot's of SortField logic was also changed and deprecations removed (not yet complete, HitCollector is still there). But with this patch most of the deprecated sort logic is removed (old Collectors, old sorting collectors, legacy search,...)

        I also converted the Sort() ctors/setSort methods to varargs and changed the tests. It's now easier to use.

        Will commit, when all tests were run again and nobody complains. This patch may miss to remove some dead code, but this should be done later, when the inventors of the new Search API look closer over it.

        Show
        Uwe Schindler added a comment - This patch removes ExtendedFieldCache bw layer. It also removes the AUTO and CUSTOM caches. Because of that, also lot's of SortField logic was also changed and deprecations removed (not yet complete, HitCollector is still there). But with this patch most of the deprecated sort logic is removed (old Collectors, old sorting collectors, legacy search,...) I also converted the Sort() ctors/setSort methods to varargs and changed the tests. It's now easier to use. Will commit, when all tests were run again and nobody complains. This patch may miss to remove some dead code, but this should be done later, when the inventors of the new Search API look closer over it.
        Hide
        Uwe Schindler added a comment -

        Committed revision: 824699

        Show
        Uwe Schindler added a comment - Committed revision: 824699
        Hide
        Uwe Schindler added a comment -

        Some small additional deprecated removals after finishing the rest. Will commit now.

        Show
        Uwe Schindler added a comment - Some small additional deprecated removals after finishing the rest. Will commit now.
        Hide
        Uwe Schindler added a comment -

        Committed revision: 824792

        Show
        Uwe Schindler added a comment - Committed revision: 824792
        Hide
        Uwe Schindler added a comment -

        Attached is the patch, committed in 3.0 branch and trunk (rev 893104) that fixes the accidental remove of SortField.getComparatorSource().

        Thanks John Wang!

        Show
        Uwe Schindler added a comment - Attached is the patch, committed in 3.0 branch and trunk (rev 893104) that fixes the accidental remove of SortField.getComparatorSource(). Thanks John Wang!

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Uwe Schindler
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development