Lucene - Core
  1. Lucene - Core
  2. LUCENE-1961

Remove remaining deprecations in document package

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Component/s: core/other
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      Remove different deprecated APIs:

      • Field.Index.NO_NORMS, etc.
      • Field.binaryValue()
      • getOmitTf()/setOmitTf()
      1. lucene-1961.patch
        25 kB
        Michael Busch

        Activity

        Hide
        Michael Busch added a comment -

        All tests pass.

        Show
        Michael Busch added a comment - All tests pass.
        Hide
        Michael Busch added a comment -

        Committed revision 823252.

        Show
        Michael Busch added a comment - Committed revision 823252.
        Hide
        Michael McCandless added a comment -

        I'm seeing this when I run "ant test-tag":

        test-tag:
            [mkdir] Created dir: /lucene/clean/build/lucene_2_9_back_compat_tests_20091008
            [mkdir] Created dir: /lucene/clean/build/lucene_2_9_back_compat_tests_20091008/classes/java
            [javac] Compiling 413 source files to /lucene/clean/build/lucene_2_9_back_compat_tests_20091008/classes/java
            [javac] Note: Some input files use or override a deprecated API.
            [javac] Note: Recompile with -Xlint:deprecation for details.
              [jar] Building jar: /lucene/clean/build/lucene_2_9_back_compat_tests_20091008/lucene_2_9_back_compat_tests_20091008.jar
            [mkdir] Created dir: /lucene/clean/build/lucene_2_9_back_compat_tests_20091008/classes/test
            [javac] Compiling 204 source files to /lucene/clean/build/lucene_2_9_back_compat_tests_20091008/classes/test
            [javac] /lucene/clean/tags/lucene_2_9_back_compat_tests_20091008/src/test/org/apache/lucene/index/DocHelper.java:172: cannot find symbol
            [javac] symbol  : method getOmitTermFreqAndPositions()
            [javac] location: interface org.apache.lucene.document.Fieldable
            [javac]       if (f.getOmitTermFreqAndPositions()) add(noTf,f);
            [javac]            ^
            [javac] /lucene/clean/tags/lucene_2_9_back_compat_tests_20091008/src/test/org/apache/lucene/index/TestFieldsReader.java:75: cannot find symbol
            [javac] symbol  : method getOmitTermFreqAndPositions()
            [javac] location: interface org.apache.lucene.document.Fieldable
            [javac]     assertTrue(field.getOmitTermFreqAndPositions() == false);
            [javac]                     ^
            [javac] /lucene/clean/tags/lucene_2_9_back_compat_tests_20091008/src/test/org/apache/lucene/index/TestFieldsReader.java:83: cannot find symbol
            [javac] symbol  : method getOmitTermFreqAndPositions()
            [javac] location: interface org.apache.lucene.document.Fieldable
            [javac]     assertTrue(field.getOmitTermFreqAndPositions() == false);
            [javac]                     ^
            [javac] /lucene/clean/tags/lucene_2_9_back_compat_tests_20091008/src/test/org/apache/lucene/index/TestFieldsReader.java:91: cannot find symbol
            [javac] symbol  : method getOmitTermFreqAndPositions()
            [javac] location: interface org.apache.lucene.document.Fieldable
            [javac]     assertTrue(field.getOmitTermFreqAndPositions() == true);
            [javac]                     ^
            [javac] Note: Some input files use or override a deprecated API.
            [javac] Note: Recompile with -Xlint:deprecation for details.
            [javac] 4 errors
        

        I think you have to add Fieldable.getOmitTFAP on the back compat branch's src/java?

        Show
        Michael McCandless added a comment - I'm seeing this when I run "ant test-tag": test-tag: [mkdir] Created dir: /lucene/clean/build/lucene_2_9_back_compat_tests_20091008 [mkdir] Created dir: /lucene/clean/build/lucene_2_9_back_compat_tests_20091008/classes/java [javac] Compiling 413 source files to /lucene/clean/build/lucene_2_9_back_compat_tests_20091008/classes/java [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [jar] Building jar: /lucene/clean/build/lucene_2_9_back_compat_tests_20091008/lucene_2_9_back_compat_tests_20091008.jar [mkdir] Created dir: /lucene/clean/build/lucene_2_9_back_compat_tests_20091008/classes/test [javac] Compiling 204 source files to /lucene/clean/build/lucene_2_9_back_compat_tests_20091008/classes/test [javac] /lucene/clean/tags/lucene_2_9_back_compat_tests_20091008/src/test/org/apache/lucene/index/DocHelper.java:172: cannot find symbol [javac] symbol : method getOmitTermFreqAndPositions() [javac] location: interface org.apache.lucene.document.Fieldable [javac] if (f.getOmitTermFreqAndPositions()) add(noTf,f); [javac] ^ [javac] /lucene/clean/tags/lucene_2_9_back_compat_tests_20091008/src/test/org/apache/lucene/index/TestFieldsReader.java:75: cannot find symbol [javac] symbol : method getOmitTermFreqAndPositions() [javac] location: interface org.apache.lucene.document.Fieldable [javac] assertTrue(field.getOmitTermFreqAndPositions() == false ); [javac] ^ [javac] /lucene/clean/tags/lucene_2_9_back_compat_tests_20091008/src/test/org/apache/lucene/index/TestFieldsReader.java:83: cannot find symbol [javac] symbol : method getOmitTermFreqAndPositions() [javac] location: interface org.apache.lucene.document.Fieldable [javac] assertTrue(field.getOmitTermFreqAndPositions() == false ); [javac] ^ [javac] /lucene/clean/tags/lucene_2_9_back_compat_tests_20091008/src/test/org/apache/lucene/index/TestFieldsReader.java:91: cannot find symbol [javac] symbol : method getOmitTermFreqAndPositions() [javac] location: interface org.apache.lucene.document.Fieldable [javac] assertTrue(field.getOmitTermFreqAndPositions() == true ); [javac] ^ [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] 4 errors I think you have to add Fieldable.getOmitTFAP on the back compat branch's src/java?
        Hide
        Michael Busch added a comment -

        I committed a fix for this to the back-compat branch but didn't create a new tag yet. Shall I create a new one?

        Show
        Michael Busch added a comment - I committed a fix for this to the back-compat branch but didn't create a new tag yet. Shall I create a new one?
        Hide
        Michael McCandless added a comment -

        I committed a fix for this to the back-compat branch but didn't create a new tag yet. Shall I create a new one?

        OK thanks.

        Don't bother creating a new one – I'm about to commit LUCENE-1950 and LUCENE-1951, both of which have back compat changes, and then I'll cut a new tag!

        Show
        Michael McCandless added a comment - I committed a fix for this to the back-compat branch but didn't create a new tag yet. Shall I create a new one? OK thanks. Don't bother creating a new one – I'm about to commit LUCENE-1950 and LUCENE-1951 , both of which have back compat changes, and then I'll cut a new tag!
        Hide
        Michael Busch added a comment -

        Cool, thanks!

        Show
        Michael Busch added a comment - Cool, thanks!

          People

          • Assignee:
            Michael Busch
            Reporter:
            Michael Busch
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development