Lucene - Core
  1. Lucene - Core
  2. LUCENE-1945

Make all classes that have a close() methods instanceof Closeable (Java 1.5)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.9
    • Fix Version/s: 3.0
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      This should be simple.

      1. LUCENE-1945.patch
        11 kB
        Uwe Schindler

        Activity

        Uwe Schindler created issue -
        Hide
        Uwe Schindler added a comment -

        Patch that adds Closeable to all public interfaces/super-classes that define close(). Package-private classes inside oal.index are not changed (as they often only define package-private close())

        Will commit soon.

        Show
        Uwe Schindler added a comment - Patch that adds Closeable to all public interfaces/super-classes that define close(). Package-private classes inside oal.index are not changed (as they often only define package-private close()) Will commit soon.
        Uwe Schindler made changes -
        Field Original Value New Value
        Attachment LUCENE-1945.patch [ 12422512 ]
        Hide
        Uwe Schindler added a comment -

        Committed revision: 826540

        Show
        Uwe Schindler added a comment - Committed revision: 826540
        Uwe Schindler made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Uwe Schindler [ thetaphi ]
        Resolution Fixed [ 1 ]
        uschindler committed 826542 (1 file)
        Reviews: none

        LUCENE-1945: add changes.txt entry

        Hide
        Earwin Burrfoot added a comment -

        Package-private classes might as well implement public close(), nobody's gonna see this method from outside anyway.

        Show
        Earwin Burrfoot added a comment - Package-private classes might as well implement public close(), nobody's gonna see this method from outside anyway.
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Mark Thomas made changes -
        Workflow jira [ 12478575 ] Default workflow, editable Closed status [ 12561856 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12561856 ] jira [ 12582920 ]

          People

          • Assignee:
            Uwe Schindler
            Reporter:
            Uwe Schindler
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development