Lucene - Core
  1. Lucene - Core
  2. LUCENE-1934

Rework (Float)LatLng implementation and distance calculation

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.9
    • Fix Version/s: 4.0-BETA
    • Component/s: modules/spatial
    • Labels:
      None
    • Lucene Fields:
      Patch Available

      Description

      Clean up of the code and normalisation of the distance calculation to standard

      1. LUCENE-1934.patch
        6 kB
        Nicolas Helleringer

        Issue Links

          Activity

          Hide
          Nicolas Helleringer added a comment -

          Initial release of path :

          • Removed loop for % use in longitude normalisation
          • Recoded the Maths around distance calculation using well know implementation (ref: http://www.movable-type.co.uk/scripts/latlong.html)
          • Changed UnitTest on doubles to use precision instead of exact comparaison (1e-4 of a mile precision)
          • Introduced and spread the use of static initialized constants

          May need some more work around class def and methods (used/not, static/not, etc ..)

          Show
          Nicolas Helleringer added a comment - Initial release of path : Removed loop for % use in longitude normalisation Recoded the Maths around distance calculation using well know implementation (ref: http://www.movable-type.co.uk/scripts/latlong.html ) Changed UnitTest on doubles to use precision instead of exact comparaison (1e-4 of a mile precision) Introduced and spread the use of static initialized constants May need some more work around class def and methods (used/not, static/not, etc ..)
          Hide
          Nicolas Helleringer added a comment -

          Forgot :

          • Removed local implementation of a degree to radian converter. Used Math.toRadians instead.
          Show
          Nicolas Helleringer added a comment - Forgot : Removed local implementation of a degree to radian converter. Used Math.toRadians instead.
          Hide
          Michael McCandless added a comment -

          Note that there is something of a rework pending on contrib/spatial – see http://lucene.markmail.org/message/4gaajqmhuxpwla7c – maybe sync up w/ Chris to make sure this patch and his work fit together?

          Show
          Michael McCandless added a comment - Note that there is something of a rework pending on contrib/spatial – see http://lucene.markmail.org/message/4gaajqmhuxpwla7c – maybe sync up w/ Chris to make sure this patch and his work fit together?
          Hide
          Nicolas Helleringer added a comment -

          As Chris work is being released outside Lucene Apache project (http://www.jteam.nl/news/spatialsolr), should we consider this patch to be re evaluated to commit ?

          Show
          Nicolas Helleringer added a comment - As Chris work is being released outside Lucene Apache project ( http://www.jteam.nl/news/spatialsolr ), should we consider this patch to be re evaluated to commit ?
          Hide
          Nicolas Helleringer added a comment -

          This has to be reworked when LUCENE-2359 and LUCENE-2366 will be closed to match code produced there.

          Show
          Nicolas Helleringer added a comment - This has to be reworked when LUCENE-2359 and LUCENE-2366 will be closed to match code produced there.
          Hide
          Erick Erickson added a comment -

          2013 Old JIRA cleanup

          Show
          Erick Erickson added a comment - 2013 Old JIRA cleanup
          Hide
          David Smiley added a comment -

          Closing because the old spatial contrib module referenced here no longer exists as of Solr 4.

          Show
          David Smiley added a comment - Closing because the old spatial contrib module referenced here no longer exists as of Solr 4.

            People

            • Assignee:
              Unassigned
              Reporter:
              Nicolas Helleringer
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development