Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-1925

In IndexSearcher class, make subReader and docCount arrays protected so sub classes can access them

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 2.9
        • Fix Version/s: 3.0
        • Component/s: core/search
        • Labels:
          None
        • Lucene Fields:
          New

          Description

          Please make these two member variables protected so subclasses can access them, e.g.:

          protected IndexReader[] subReaders;
          protected int[] docStarts;

          Thanks

          1. Text File
            LUCENE-1925.patch
            1 kB
            Michael McCandless

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            mikemccand Michael McCandless added a comment -

            +1

            We should also reserve future non back compatibility (mark them "expert/subject to suddenly change").

            Show
            mikemccand Michael McCandless added a comment - +1 We should also reserve future non back compatibility (mark them "expert/subject to suddenly change").
            Hide
            Permalink
            tsmith Tim Smith added a comment -

            i would also like to see a protected constructor that takes:
            IndexSearcher(IndexReader reader, IndexReader[] subReaders, int[] docOffsets)

            this way a subclass can avoid any constructor costs and pass exactly the sub readers/offsets it wants
            this constructor would also be marked "expert/subject to change" of course

            Show
            tsmith Tim Smith added a comment - i would also like to see a protected constructor that takes: IndexSearcher(IndexReader reader, IndexReader[] subReaders, int[] docOffsets) this way a subclass can avoid any constructor costs and pass exactly the sub readers/offsets it wants this constructor would also be marked "expert/subject to change" of course
            Hide
            Permalink
            mikemccand Michael McCandless added a comment -

            Attached patch, making the members protected & added expert ctor.

            Show
            mikemccand Michael McCandless added a comment - Attached patch, making the members protected & added expert ctor.
            Hide
            Permalink
            mikemccand Michael McCandless added a comment -

            Thanks John & Tim!

            Show
            mikemccand Michael McCandless added a comment - Thanks John & Tim!

              People

              • Assignee:
                mikemccand Michael McCandless
                Reporter:
                john.wang@gmail.com John Wang
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development