Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Component/s: core/search
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      LUCENE-1290 removed all references to Hits from core.

      Most work to be done here is to remove all references from the contrib modules and some new ones that crept into core after 1290.

      1. lucene-1856-javadocs.patch
        3 kB
        Michael Busch
      2. lucene-1856.patch
        104 kB
        Michael Busch

        Activity

        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12563115 ] jira [ 12584184 ]
        Mark Thomas made changes -
        Workflow jira [ 12474125 ] Default workflow, editable Closed status [ 12563115 ]
        Uwe Schindler made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Michael Busch made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Michael Busch added a comment -

        Committed the latest patch.

        Show
        Michael Busch added a comment - Committed the latest patch.
        Michael Busch made changes -
        Attachment lucene-1856-javadocs.patch [ 12421558 ]
        Michael Busch made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Michael Busch added a comment -

        Oh man, I didn't even remove the classes (Hits, Hit, HitIterator) themselves

        Forgot the 'svn rm' after applying the patch. 'svn patch', when are you finally coming?

        Show
        Michael Busch added a comment - Oh man, I didn't even remove the classes (Hits, Hit, HitIterator) themselves Forgot the 'svn rm' after applying the patch. 'svn patch', when are you finally coming?
        Hide
        Michael Busch added a comment -

        Thanks, Earwin, good catch. I'll remove them.

        Show
        Michael Busch added a comment - Thanks, Earwin, good catch. I'll remove them.
        Hide
        Earwin Burrfoot added a comment -

        Still some javadocs referencing Hits remaining, as well as Hits/Hit/HitIterator themselves. Is that okay?

        Show
        Earwin Burrfoot added a comment - Still some javadocs referencing Hits remaining, as well as Hits/Hit/HitIterator themselves. Is that okay?
        Michael Busch made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Michael Busch added a comment -

        Committed revision 822587.

        Show
        Michael Busch added a comment - Committed revision 822587.
        buschmi committed 822587 (24 files)
        Reviews: none

        LUCENE-1856: Remove Hits.

        Lucene trunk
        buschmi committed 822582 (1 file)
        Reviews: none

        LUCENE-1856: New tag after removing Hits from tests.

        Michael Busch made changes -
        Attachment lucene-1856.patch [ 12421477 ]
        Hide
        Michael Busch added a comment -

        Removes Hits from core and all contribs.

        All core and contrib tests pass. I'll have to commit some changes also to the bw-compat branch.

        Show
        Michael Busch added a comment - Removes Hits from core and all contribs. All core and contrib tests pass. I'll have to commit some changes also to the bw-compat branch.
        Michael Busch made changes -
        Priority Major [ 3 ] Minor [ 4 ]
        Michael Busch made changes -
        Field Original Value New Value
        Assignee Michael Busch [ michaelbusch ]
        Michael Busch created issue -

          People

          • Assignee:
            Michael Busch
            Reporter:
            Michael Busch
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development