Lucene - Core
  1. Lucene - Core
  2. LUCENE-1794

implement reusableTokenStream for all contrib analyzers

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9
    • Component/s: modules/analysis
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      most contrib analyzers do not have an impl for reusableTokenStream

      regardless of how expensive the back compat reflection is for indexing speed, I think we should do this to mitigate any performance costs. hey, overall it might even be an improvement!

      the back compat code for non-final analyzers is already in place so this is easy money in my opinion.

      1. LUCENE-1794-reusing-analyzer.patch
        6 kB
        Shai Erera
      2. LUCENE-1794.patch
        56 kB
        Robert Muir
      3. LUCENE-1794.patch
        57 kB
        Robert Muir
      4. LUCENE-1794.patch
        60 kB
        Robert Muir
      5. LUCENE-1794.patch
        74 kB
        Robert Muir
      6. LUCENE-1794.patch
        82 kB
        Robert Muir
      7. LUCENE-1794.patch
        96 kB
        Robert Muir
      8. LUCENE-1794_fix2.txt
        15 kB
        Robert Muir
      9. LUCENE-1794_fix.patch
        11 kB
        Robert Muir

        Issue Links

          Activity

          Robert Muir created issue -
          Robert Muir made changes -
          Field Original Value New Value
          Component/s contrib/analyzers [ 12312333 ]
          Robert Muir made changes -
          Attachment LUCENE-1794.patch [ 12416047 ]
          Robert Muir made changes -
          Attachment LUCENE-1794.patch [ 12416058 ]
          Robert Muir made changes -
          Fix Version/s 2.9 [ 12312682 ]
          Robert Muir made changes -
          Attachment LUCENE-1794.patch [ 12416191 ]
          Robert Muir made changes -
          Attachment LUCENE-1794.patch [ 12416376 ]
          Robert Muir made changes -
          Attachment LUCENE-1794.patch [ 12416426 ]
          Robert Muir made changes -
          Link This issue is blocked by LUCENE-1801 [ LUCENE-1801 ]
          Robert Muir made changes -
          Attachment LUCENE-1794.patch [ 12416586 ]
          Shai Erera made changes -
          Attachment LUCENE-1794-reusing-analyzer.patch [ 12416670 ]
          Robert Muir made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Robert Muir made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Robert Muir made changes -
          Attachment LUCENE-1794_fix.patch [ 12416879 ]
          Robert Muir made changes -
          Attachment LUCENE-1794_fix2.txt [ 12416940 ]
          Robert Muir made changes -
          Status Reopened [ 4 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Mark Miller made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Mark Thomas made changes -
          Workflow jira [ 12472775 ] Default workflow, editable Closed status [ 12563294 ]
          Mark Thomas made changes -
          Workflow Default workflow, editable Closed status [ 12563294 ] jira [ 12584405 ]
          Shai Erera made changes -
          Component/s modules/analysis [ 12310230 ]
          Component/s contrib/analyzers [ 12312333 ]

            People

            • Assignee:
              Robert Muir
              Reporter:
              Robert Muir
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development