Lucene - Core
  1. Lucene - Core
  2. LUCENE-167

[PATCH] QueryParser not handling queries containing AND and OR


    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: core/queryparser
    • Labels:
    • Environment:

      Operating System: Linux
      Platform: PC


      The QueryParser does not seem to handle boolean queries containing AND and OR
      operators correctly:
      a AND b OR c AND d gets parsed as +a +b +c +d.

      The attached patch fixes this by changing the vector of boolean clauses into a
      vector of vectors of boolean clauses in the addClause method of the query
      parser. A new sub-vector is created whenever an explicit OR operator is used.

      Queries using explicit AND/OR are grouped by precedence of AND over OR. That is
      a OR b AND c gets a OR (b AND c).

      Queries using implicit AND/OR (depending on the default operator) are handled as
      before (so one can still use a +b -c to create one boolean query, where b is
      required, c forbidden and a optional).

      It's less clear how a query using both explizit AND/OR and implicit operators
      should be handled.
      Since the patch groups on explicit OR operators a query
      a OR b c is read as a (b c)
      a AND b c as +a +b c
      (given that default operator or is used).

      There's one issue left:
      The old query parser reads a query
      `a OR NOT b' as `a -b' which is the same as `a AND NOT b'.
      The modified query parser reads this as `a (-b)'.
      While this looks better (at least to me), it does not produce the result of a OR
      NOT b. Instead the (-b) part seems to be silently dropped.
      While I understand that this query is illegal (just searching for one negative
      term) I don't think that silently dropping this part is an appropriate way to
      deal with that. But I don't think that's a query parser issue.
      The only question is, if the query parser should take care of that.

      I attached the patch (made against 1.3rc3 but working for 1.3final as well) and
      a test program.
      The test program parses a number of queries with default-or and default-and
      operator and reparses the result of the toString method of the created query.
      It outputs the initial query, the parsed query with default or, the reparesed
      query, the parsed query with the default and it's reparsed query.
      If called with a -q option, it also run's the queries against an index
      consisting of all documentes containing one or none a b c or d.
      Using an unpatched and a patched version of lucene in the classpath one can look
      at the effect of the patch in detail.

        Issue Links


          Steve Rowe made changes -
          Affects Version/s unspecified [ 12310280 ]
          Mark Thomas made changes -
          Workflow Default workflow, editable Closed status [ 12564440 ] jira [ 12585717 ]
          Mark Thomas made changes -
          Workflow jira [ 12324322 ] Default workflow, editable Closed status [ 12564440 ]
          Morus Walter made changes -
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Luis Alves made changes -
          Link This issue is part of LUCENE-1823 [ LUCENE-1823 ]
          Jeff Turner made changes -
          Field Original Value New Value
          issue.field.bugzillaimportkey 25820 12314317
          Morus Walter created issue -


            • Assignee:
              Erik Hatcher
              Morus Walter
            • Votes:
              2 Vote for this issue
              1 Start watching this issue


              • Created: