Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-1662

consolidate FieldCache and ExtendedFieldCache instances

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9
    • Component/s: None
    • Labels:
      None
    • Lucene Fields:
      New

      Description

      It's confusing and error prone having two instances of FieldCache... FieldCache .DEFAULT and ExtendedFieldCache .EXT_DEFAULT.
      Accidentally use the wrong one and you silently double the memory usage for that field. Since ExtendedFieldCache extends FieldCache, there's no reason not to share the same instance across both.

        Activity

        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        committed.

        Show
        yseeley@gmail.com Yonik Seeley added a comment - committed.
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        Patch attached... all tests pass and I plan on committing shortly.

        Show
        yseeley@gmail.com Yonik Seeley added a comment - Patch attached... all tests pass and I plan on committing shortly.

          People

          • Assignee:
            Unassigned
            Reporter:
            yseeley@gmail.com Yonik Seeley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development