Uploaded image for project: 'Lucene - Core'
  1. Lucene - Core
  2. LUCENE-1658

Absorb NIOFSDirectory into FSDirectory

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 2.9
    • core/store
    • None
    • New

    Description

      I think whether one uses java.io.* vs java.nio.* or eventually
      java.nio2.*, or some other means, is an under-the-hood implementation
      detail of FSDirectory and doesn't merit a whole separate class.

      I think FSDirectory should be the core class one uses when one's index
      is in the filesystem.

      So, I'd like to deprecate NIOFSDirectory, absorbing it into
      FSDirectory, and add a setting "useNIO" to FSDirectory. It should
      default to "true" for non-Windows OSs, because it gives far better
      concurrent performance on all platforms but Windows (due to known Sun
      JRE issue http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6265734).

      Attachments

        1. LUCENE-1658.patch
          7 kB
          Michael McCandless
        2. LUCENE-1658.patch
          42 kB
          Michael McCandless
        3. LUCENE-1658.patch
          43 kB
          Michael McCandless
        4. LUCENE-1658-take2.patch
          37 kB
          Uwe Schindler
        5. LUCENE-1658-take2.patch
          38 kB
          Uwe Schindler
        6. LUCENE-1658-take3.patch
          20 kB
          Uwe Schindler
        7. LUCENE-1658-take3.patch
          20 kB
          Uwe Schindler
        8. LUCENE-1658-take3.patch
          24 kB
          Uwe Schindler
        9. LUCENE-1658-take3.patch
          27 kB
          Uwe Schindler
        10. LUCENE-1658-take3.patch
          34 kB
          Uwe Schindler
        11. LUCENE-1658-take3.patch
          41 kB
          Uwe Schindler
        12. LUCENE-1658-take3.patch
          44 kB
          Uwe Schindler

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            uschindler Uwe Schindler
            mikemccand Michael McCandless
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment